Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvments... #2116

Closed
4 tasks done
ng8weji9vowdv opened this issue Aug 15, 2024 · 3 comments
Closed
4 tasks done

UI improvments... #2116

ng8weji9vowdv opened this issue Aug 15, 2024 · 3 comments

Comments

@ng8weji9vowdv
Copy link

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Description

.

@ng8weji9vowdv
Copy link
Author

ng8weji9vowdv commented Aug 15, 2024

So, the main and primary issue for my case is when i am using the scene detector and let's say it creates 10000 segments, and the tool fails to process them after 8-9%, and stucks there with no progress being applied neither to the files nor in UI.

Joining segments

The other issue, is obvious being unable to put segments back together, unite them, instead of splitting (which makes the tool pretty lame, its just an array of segments, why can't we just unite 2 or more segments and work with them as a unit?)...

Update, found, under segments combine selected segments, but should be duplicated for individual segments in context menu for the right mouse button click.

Never-mind even this has a bug. So i clicked that and the last segment is missing in the list lol, but it displays it as the first segment for some reason with the duration of 14 hours instead (???)
...
image
4 in total, 2 in the middle are the ones that i unselected, but in the list i can only observe 3, the last one is missing.
Now i have to rerun scene detector and wait for 3 hours to get the result... Bruh.
Ctrl + z ctrl + shit + z helped.

Either way, due to not creating the segments correctly when the segments in the middle are being marked as unselected it thinks that it confuses the start and end, so it renders the same exact file (3gb+ of 14 hours), lol. You need to fix that too ig.

So to repeat, make like 20 random segments, uncheck 2 big chunks in the middle and then use Segments -> Combine, and then render, you will get the same file most likely.

I ended up manually creating segments and idk, rendering them ig? Annoying a little, so id rather have it done automatically in the correct way.

Progress bar

The third issue, this annoying ass bar that overlaps the segments.
image
Like imagine being on the edge of a segment and this thing overlaps it, because of centering (oh yeah, sometimes it goes outside of the observable space, so the cursor gets off the screen, somewhere in the right or left depending where you are at)? Lol.

Zooming animations/Animations

Besides that, these zoom in zoom out animations (and the rest of them too, select unselect segment for example) are horrendous but no options to turn them off truly, it wouldve been much better if while zooming in id not have to wait 3 seconds until the things appear under my mouse cursor.

Besides that animation issue the zooming itself has an individual issue. let's say you are zooming in and you're on like 4096x zoom, and you use ctrl + mouse wheel down you expect it step down, but no, instead it goes on zoom 1x lol.

Scroll bar for segments

Also, the segments scroll bar, as i said let's imagine we have like 10000 segments, and there's no scroll bar you literally used to either seek in the bar or scroll down.

To implement the segments join (unite) you have to also add support of selecting items with ctrl + click, and the other way is:
select item

scroll down all until you meet the needed segment and use ctrl + shift or something to select all segment between two segments.

It can work for both individual segments selection (as in final result) or to join them later via the context menu.
(Just fix the bug described above)

Exporting frames

And finally, since you're creating the llc file -proj.llc, then why do we not have a simple export all segments into a json file button, for later processing via ffmpeg manually. P.s. in current mode 'last ffmpeg commands' button is useless since its only displaying (and not all the time) successful commands, but it should display all of them before running them, just add into the list and let people run manually.

Additionally it would be nice to have a simple seconds (not milliseconds) counter in the progress bar or at least see the seconds/timestamp (should be available to switch) of segment start and segment end in segments list.
image

Because here in segments json file we only have the areas in seconds (right now we only can observe start end in regular time alike and the duration is in ms).

Overall, tool is fine.

@mifi
Copy link
Owner

mifi commented Aug 23, 2024

So, the main and primary issue for my case is when i am using the scene detector and let's say it creates 10000 segments, and the tool fails to process them after 8-9%, and stucks there with no progress being applied neither to the files nor in UI.

I think #1727

I ended up manually creating segments and idk, rendering them ig? Annoying a little, so id rather have it done automatically in the correct way.

It's hard to follow your explanations. maybe you can create a bug report with exact steps to reproduce the problem and what you see and what you expect t osee:

https://github.com/mifi/lossless-cut/issues/new?assignees=&labels=&projects=&template=2-bug.yml

Like imagine being on the edge of a segment and this thing overlaps it, because of centering (oh yeah, sometimes it goes outside of the observable space, so the cursor gets off the screen, somewhere in the right or left depending where you are at)? Lol.

your screenshot does not illustrate what's the problem. why is it a problem that the translucent background overlaps a segment?

oh yeah, sometimes it goes outside of the observable space

I don't know what that means

Besides that, these zoom in zoom out animations (and the rest of them too, select unselect segment for example) are horrendous but no options to turn them off truly, it wouldve been much better if while zooming in id not have to wait 3 seconds until the things appear under my mouse cursor.

you can enable "reduced motion" in your OS and it should respect that setting and disable animations in the app. does that work?

let's say you are zooming in and you're on like 4096x zoom, and you use ctrl + mouse wheel down you expect it step down, but no, instead it goes on zoom 1x lol.

not able to repro this. when i ctrl+wheel down it doesn't go to 1x. could you record a video or screenshots with explanation?

and there's no scroll bar you literally used to either seek in the bar or scroll down.

I will add a scrollbar

And finally, since you're creating the llc file -proj.llc, then why do we not have a simple export all segments into a json file button, for later processing via ffmpeg manually.

not sure what you mean by this but File -> export project(llc) will export all segments into a json file.

Additionally it would be nice to have a simple seconds (not milliseconds) counter in the progress bar or at least see the seconds/timestamp (should be available to switch) of segment start and segment end in segments list.

which progress bar are you talking about that has a milliseconds counter?

Because here in segments json file we only have the areas in seconds (right now we only can observe start end in regular time alike and the duration is in ms).

?

it should display all of them before running them, just add into the list and let people run manually.

not clear how this should work. #974 ?

mifi added a commit that referenced this issue Oct 7, 2024
when hovering it with mouse
closes #2177
also possibly #2116
@mifi
Copy link
Owner

mifi commented Nov 28, 2024

closing due to lack of response

@mifi mifi closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants