Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage does not provide a valid icon for linux desktop integration. #2237

Open
4 tasks done
ensonic opened this issue Nov 3, 2024 · 1 comment
Open
4 tasks done
Labels
bug Electron Upstream electron or electron builder bug Linux Appears on Linux based OSes

Comments

@ensonic
Copy link

ensonic commented Nov 3, 2024

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

Operating System

Linux

Steps to reproduce

./appimagelint-x86_64.AppImage LosslessCut-linux-x86_64.AppImage
...
ppimagelint.cli[21500] [INFO] Running check "Icons validity and location check"
appimagelint.icons_check[21500] [INFO] Extracting icon name from desktop file: /tmp/.mount_LosslesTZwTf/losslesscut.desktop
appimagelint.icons_check[21500] [INFO] Checking resolution of icon: /tmp/.mount_LosslesTZwTf/losslesscut.png
appimagelint.icons_check[21500] [INFO] [✔] Valid icon in AppDir root
appimagelint.icons_check[21500] [INFO] Checking resolution of icon: /tmp/.mount_LosslesTZwTf/.DirIcon
appimagelint.icons_check[21500] [INFO] [✔] Valid icon file in .DirIcon
appimagelint.icons_check[21500] [INFO] Checking resolution of icon: /tmp/.mount_LosslesTZwTf/usr/share/icons/hicolor/0x0/apps/losslesscut.png
appimagelint.icons_check[21500] [ERROR] Icon resolution doesn't match resolution in path: (0, 0) (file resolution is (512, 512))
appimagelint.icons_check[21500] [WARNING] no other icons found
appimagelint.icons_check[21500] [INFO] [✖] Other integration icons valid

Expected behavior

I am using https://github.com/TheAssassin/AppImageLauncher and I would expect an icon with the desktop entry.

Actual behavior

Fallback icon used.

Share log from developer tools

See log in repro. Tool used: https://github.com/TheAssassin/appimagelint

@ensonic
Copy link
Author

ensonic commented Nov 3, 2024

I did a bit more research, and this is actually: electron-userland/electron-builder#5294

@mifi mifi added bug Linux Appears on Linux based OSes Electron Upstream electron or electron builder bug labels Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Electron Upstream electron or electron builder bug Linux Appears on Linux based OSes
Projects
None yet
Development

No branches or pull requests

2 participants