Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report assemblies which exist in an incorrect version #7

Open
agross opened this issue Oct 31, 2013 · 7 comments
Open

Report assemblies which exist in an incorrect version #7

agross opened this issue Oct 31, 2013 · 7 comments

Comments

@agross
Copy link
Contributor

agross commented Oct 31, 2013

For an executable that references a custom strong-named assembly that is only available in an incorrect version, report the reference.

@mikehadlow
Copy link
Owner

Yes, that would be very nice. Would you care to take a look at the code and see if you can implement it. I'd welcome a pull request.

@agross
Copy link
Contributor Author

agross commented Nov 4, 2013

This is as far as I got: agross/AsmSpy@24176b40eddc3db9378d79eff33eef4d306c26c0

What I found interesting that I got several FileNotFoundExceptions for the directory I tested against, although the assemblies in question are readable.

I'd appreciate a review.

@mikehadlow
Copy link
Owner

Hi Alexander,
Very busy at the moment, but I'll try to get around to it if possible.
Thanks
Mike

On Mon, Nov 4, 2013 at 2:14 PM, Alexander Groß [email protected]:

This is as far as I got: agross/AsmSpy@24176b4https://github.com/agross/AsmSpy/commit/24176b40eddc3db9378d79eff33eef4d306c26c0

What I found interesting that I got several FileNotFoundExceptions for
the directory I tested against, although the assemblies in question are
readable.

I'd appreciate a review.


Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-27687340
.

@rahulpnath
Copy link
Collaborator

@agross If you still remember what this is :)
Does this also not depend on the assembly binding redirects? So it is still be valid to have a different version in the references than that is present in the bin/application directory

@agross
Copy link
Contributor Author

agross commented Jul 17, 2016

AFAIR we didn't have binding redirects in the tested directory.

@agross
Copy link
Contributor Author

agross commented Jul 17, 2016

I think I remember that the reason we were looking at AsmSpy at that time was that our application didn't run, despite all assemblies being correct. Or so we thought. I created the issue because of this as displaying version mismatches would have helped us identifying the culprit (wrong assembly version in bin directory) faster.

@rahulpnath
Copy link
Collaborator

Cool thanks @agross for confirming. But The fix for this will need to check assembly binding entries too and not just the assembly version that an exe refers too. @mikehadlow Any thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants