Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need clear all subscription method #121

Open
rupeshtiwari opened this issue Nov 21, 2018 · 0 comments
Open

need clear all subscription method #121

rupeshtiwari opened this issue Nov 21, 2018 · 0 comments

Comments

@rupeshtiwari
Copy link

rupeshtiwari commented Nov 21, 2018

Hi
In our angular test cases project, we are using amplifyJS and each time we inject ampilfyjs we want to clear all of its previous subscriptions. Since it is singleton service in angular project this function is called once and all subscriptions remains.
If you check any pubsub library it is common practice to have clearAllSubscriptions method. Therefore, its good idea to put it in. I am willing to submit PR for this change and I hope it is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant