Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority: Restructure Repository #32

Open
miketheprogrammer opened this issue Nov 20, 2014 · 4 comments
Open

Priority: Restructure Repository #32

miketheprogrammer opened this issue Nov 20, 2014 · 4 comments

Comments

@miketheprogrammer
Copy link
Owner

Move (window, menu, session ) => src/bindings/
Expose NewWindow NewMenu NewSession via package Thrust
Figure out what the best option is for Spawn, Connection, Commands, Dispatcher packages.
Start giving thought to public vs private api's.
Remove public directory, public directories should be tutorial and example local
Remove makefile, its stupid to have a platform dependent file.
Remove package Common, its useless, and in removing it, remove alexcasaro log, lets just use standard logger.

--- my thoughts ---
Spawn should be moved to package Thrust.

Thrust.RunCore() instead of spawn.Run
Thrust.NewWindow() instead of window.NewWindow
Thrust.NewSession() instead of session.NewSession
Thrust.NewMenu()  instead of menu.NewMenu
Thrust.RunDispatcher() instead of Dispatcher.RunLoop()

Are we bulking to much into one package, i still think src/bindings/window will have its own NewWindow method, however that is purely to resolve any cyclic issues we may encounter down the road.

@tehbilly @gerred Feel free to chime in

@spolu
Copy link
Collaborator

spolu commented Nov 20, 2014

👍

@miketheprogrammer
Copy link
Owner Author

Im hacking this out on branch refactor_4.0

@miketheprogrammer
Copy link
Owner Author

Done. Merged Into Master

@miketheprogrammer
Copy link
Owner Author

Can someone work on updating the tutorials. I just updated the Examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants