Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Web Workers #102

Open
gmaclennan opened this issue Feb 18, 2016 · 2 comments
Open

Support Web Workers #102

gmaclennan opened this issue Feb 18, 2016 · 2 comments

Comments

@gmaclennan
Copy link

When I use livereactload with a React app (0.14.7) with mapbox-gl-js I get errors with Web Workers (which mapbox-gl-js uses webworkify to create). I don't really know enough about how livereactload works to debug further. It seems to be related to module detection and browserify wrapping in the web worker? Without livereactload everything works fine. I am using babelify, seeing this in both babel v5 & v6, and both using ES2015 and CommonJS module syntax.

@milankinen
Copy link
Owner

Thanks! I'll check this. Never tried to run LiveReactload with web workers so potential bug here.

@gmaclennan
Copy link
Author

Here is my code so that you can see the problem with live loading mapbox-gl-js, on the rewrite branch: https://github.com/digidem/mapfilter/tree/rewrite

./node_modules/.bin/budo ./src/index.js:bundle.js -- -p livereactload should give the error.

@milankinen milankinen changed the title mapbox-gl-js / webworkify - Uncaught ReferenceError: modules is not defined Support Web Workers Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants