Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support factory-bundle #107

Open
yborunov opened this issue Mar 15, 2016 · 4 comments
Open

Support factory-bundle #107

yborunov opened this issue Mar 15, 2016 · 4 comments

Comments

@yborunov
Copy link

I'm using factory-bundle browserify plugin to break down my code into separate bundles and a common file for all pages. It works fine until I add livereactload. Because livereactload doesn't know how to deal with separated bundles. Is the a way to reconcile livereactload and factory-bundle?

@milankinen milankinen changed the title Does not work with factory-bundle Support factory-bundle Mar 26, 2016
@milankinen
Copy link
Owner

Hi! Unfortunately this feature would require some heavy upgrades to the codebase and I've got no time for such big changes (I'm sorry! 😞)

Keeping this issue open, if someone figures out to implement this. PR's welcome!

@yborunov
Copy link
Author

Hey, I understand, we all have day jobs. The only temporary solution I came up with is to have several browserify tasks to build separate bundles, but it doesn't create a common file, though. Even so, livereactload gives me more convenience, so I had to decide in its favor.

Hope someone or even me find time to dig into this problem and implement a solution. I'll have to wrap my head around browerify plugins API to do that, have no idea how it works so far.

@sassanh
Copy link

sassanh commented Feb 23, 2017

It's been a while since this issue is reported, I just wanna explain my workaround in case it helps others. I'm not using factor bundle, I'm using a manual partitioning method but I had this problem with my manual method too. My workaround is to use different bundling methods for development and production. For production I create all the ~12 bundles but for development I create only 2 (it could be one, but for technical irrelevant details in my project it's 2.) It's been like this for 7 months and had no problem. The only problem is this way you can't debug your partitioning method in your development setup. You should occasionally need to do so (specially if you're using factor-bundle and not a manual method) but in case you need to do so you can disable livereactload and use the same bundling method you use in production temporarily.

@milankinen
Copy link
Owner

Nice to hear that you've found a solution that works in your case and thank you for sharing it! These kind of infos are valuable. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants