Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy Profile Popout #49

Open
KingGamingYT opened this issue Jun 21, 2024 · 82 comments
Open

Legacy Profile Popout #49

KingGamingYT opened this issue Jun 21, 2024 · 82 comments

Comments

@KingGamingYT
Copy link
Collaborator

KingGamingYT commented Jun 21, 2024

With Discord's removal of the legacy profile popout experiment (2 years in the making, apparently), I'm wondering if it's possible to style the new menu to look like the old one without a status dropdown. There's also the "click to copy username" easter egg, but I doubt that's possible to be replicated without JS.
image
image
Vesktop_DEvz4WKhkj

@milbits
Copy link
Owner

milbits commented Jun 21, 2024

im workin on it! but if you have a plugin for the experiments tab, try this
image

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Jun 21, 2024

Ohp, I think there's been a bit of confusion in my wording, I'm referring to the status changer/mini profile popup next to the media controls, not the new profile popouts and full design Discord recently has been rolling out.

They had a dedicated experiment from back in 2022 to either use the new ones or change them back to how they were before, which got removed today.
image

@milbits
Copy link
Owner

milbits commented Jun 21, 2024

oops
yeah, look at this poorly done thing
image

@KingGamingYT
Copy link
Collaborator Author

progress is progress ! ! lol

@KingGamingYT
Copy link
Collaborator Author

I decided to take a small stab at it today and I'm happy with what I did get changed, but unfortunately I don't think moving the status changer back into the menu is possible with purely css :(
image

@milbits
Copy link
Owner

milbits commented Jun 23, 2024

this will drastically affect the economy...

@KingGamingYT
Copy link
Collaborator Author

im workin on it! but if you have a plugin for the experiments tab, try this image

they removed the experiment lmfao

@milbits
Copy link
Owner

milbits commented Jun 26, 2024

bruh 😭 😭 this is the fastest time that they ever removed an experiment too

they really dont want us to use the better ui huh

@KingGamingYT
Copy link
Collaborator Author

nope

no idea what you've done up to this point but in the past half hour I've managed to hack together something that's okay visually, has some issues functionally though
image

@milbits
Copy link
Owner

milbits commented Jun 26, 2024

could i get the css? i didnt really have that much time styling it
image

@aeonlight
Copy link

istg discord hates its userbase.................

@milbits
Copy link
Owner

milbits commented Jun 26, 2024

the investors probably lvoe it though

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Jun 26, 2024

could i get the css? i didnt really have that much time styling it image

Some of its taken from a snippet in the BetterDiscord server, but here it is

#account > .scrollerBase_c49869.none_c49869.scroller_d90b3d > div > .colorDefault_d90b3d.labelContainer_d90b3d.item_d90b3d, 
#account > .scrollerBase_c49869.none_c49869.scroller_d90b3d > .separator_d90b3d {
  display: none;
  }
.accountProfilePopoutWrapper_b2ca13 {
  top: 5px;
}
#status-set-custom-status > .label_d90b3d {
  text-indent: -9999px;
  line-height: 0;
}
#status-set-custom-status > .label_d90b3d::after {
  content: "Set a custom status";
  text-indent: 0;
  display: block;
  line-height: initial;
}
.accountProfilePopoutWrapper_b2ca13 .userPopoutInner_c69a7b:before,
.accountProfilePopoutWrapper_b2ca13 .wrapper_cb78f1.biteSize_cb78f1,
.accountProfilePopoutWrapper_b2ca13 .header_c6e596,
.accountProfilePopoutWrapper_b2ca13 .body_d4e7c2 div:has(.descriptionClamp_fc5c48),
.accountProfilePopoutWrapper_b2ca13 .activity_cd74cc,
.accountProfilePopoutWrapper_b2ca13 .tags_c32acf,
.accountProfilePopoutWrapper_b2ca13 .profileEffects_f867f9,
.header_b07019,
.usernameRow_c32acf {
    display: none;
}
.accountProfilePopoutWrapper_b2ca13 .body_d4e7c2 {
    padding: 8px;
    gap: 8px;
}
.accountProfilePopoutWrapper_b2ca13 .username_d4e7c2 {
    padding: 0px 8px;
}
.accountProfilePopoutWrapper_b2ca13 .menus_d4e7c2 {
    gap: 0px !important;
}
.accountProfilePopoutWrapper_b2ca13 .menu_d4e7c2 {
    background-color: transparent;
}
.accountProfilePopoutWrapper_b2ca13  .menus_d4e7c2 > .menu_d4e7c2 > .scroller_d90b3d {
    padding: 0px !important;
}
.accountProfilePopoutWrapper_b2ca13 .menu_d4e7c2:last-of-type [role="group"]:first-of-type::before {
    content: "";
    display: block;
    margin: 7px 4px 8px 4px;
    border-bottom: 1px solid var(--profile-body-divider-color);
}

.accountProfilePopoutWrapper_b2ca13 {
    left: 0px;
    bottom: 0px;
}

.accountProfilePopoutWrapper_b2ca13 .userPopoutOuter_c69a7b.userProfileOuter_c69a7b {
    width: 220px;
    background: var(--background-floating);
}
.accountProfilePopoutWrapper_b2ca13 .userPopoutInner_c69a7b {
    max-height: 100%;
    width: 220px;
    gap: 0px;
    padding-bottom: 0px;
    background: var(--background-floating);
}
#account > .scrollerBase_c49869.none_c49869.scroller_d90b3d {
  right: 20px !important; 
  margin-left: 1em !important;
}

@KingGamingYT
Copy link
Collaborator Author

image
this may be a lost cause

@milbits
Copy link
Owner

milbits commented Jun 27, 2024

what the fuck are they doing

@KingGamingYT
Copy link
Collaborator Author

can't wait to have to somehow reformat the thought bubble into a button and pull it down

@milbits
Copy link
Owner

milbits commented Jun 28, 2024

that'll be so awesome and cool!

@KingGamingYT
Copy link
Collaborator Author

they updated the classes so now my above code is already irrelevant YAYYYY

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Jun 30, 2024

Updated the classes and hopefully made it less of a mess, removed some padding in there and now I think it looks better than it did before

#account > .scrollerBase_c49869.none_c49869.scroller_d90b3d > .separator_d90b3d {
  display: none;
  }
.accountProfilePopoutWrapper_b2ca13 {
  top: 5px;
}
#status-set-custom-status > .label_d90b3d {
  text-indent: -9999px;
  line-height: 0;
}
#status-set-custom-status > .label_d90b3d::after {
  content: "Set a custom status";
  text-indent: 0;
  display: block;
  line-height: initial;
}
.accountProfilePopoutWrapper_b2ca13 .userPopoutInner_c69a7b:before,
.accountProfilePopoutWrapper_b2ca13 .wrapper_cb78f1.biteSize_cb78f1,
.accountProfilePopoutWrapper_b2ca13 .header_b07019,
.accountProfilePopoutWrapper_b2ca13 .body_ad5fac div:has(.descriptionClamp_fc5c48),
.accountProfilePopoutWrapper_b2ca13 .activity_cd74cc,
.accountProfilePopoutWrapper_b2ca13 .tags_c32acf,
.accountProfilePopoutWrapper_b2ca13 .profileEffects_f867f9,
.accountProfilePopoutWrapper_b2ca13 .usernameRow_c32acf {
    display: none;
}
.accountProfilePopoutWrapper_b2ca13 .body_ad5fac {
    padding: 0px;
    gap: 8px;
}
.accountProfilePopoutWrapper_b2ca13 .username_d4e7c2 {
    padding: 0px 8px;
}
.accountProfilePopoutWrapper_b2ca13 .menus_ad5fac {
    gap: 0px !important;
}
.accountProfilePopoutWrapper_b2ca13 .menu_ad5fac {
    background-color: transparent;
}
.accountProfilePopoutWrapper_b2ca13 .menus_ad5fac > .menu_ad5fac > .scroller_d90b3d {
    padding: 0px !important;
}
.accountProfilePopoutWrapper_b2ca13 .menu_ad5fac:last-of-type [role="menu"]:first-of-type::before {
    content: "";
    display: block;
    margin: 7px 4px 8px 4px;
    border-bottom: 1px solid var(--profile-body-divider-color);
}

.accountProfilePopoutWrapper_b2ca13 {
    left: 0px;
    bottom: 0px;
}

.accountProfilePopoutWrapper_b2ca13 .userPopoutOuter_c69a7b.userProfileOuter_c69a7b, #status > .scrollerBase_c49869.none_c49869.scroller_d90b3d {
    width: 220px;
    background: var(--background-floating);
}
.accountProfilePopoutWrapper_b2ca13 .userPopoutInner_c69a7b {
    max-height: 100%;
    width: 220px;
    gap: 0px;
    padding-bottom: 0px;
    background: var(--background-floating);
}

image

@KingGamingYT
Copy link
Collaborator Author

Added the switch accounts icon back! It's kinda small but tbh the entire menu is fucked up in such a way I don't know if I can solve
image

@KingGamingYT
Copy link
Collaborator Author

A few more tweaks before I go to bed, some padding reduction and I added a divider between the switch accounts and custom status button because that's no longer there for some reason
image

@aeonlight
Copy link

I am this close to learning how to code just to make a custom application for discord.

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Jul 3, 2024

i love css ! ! ! (you have to target all the buttons in the menu separately) ((these divs are making me lose my mind))
image

@milbits
Copy link
Owner

milbits commented Jul 3, 2024

nesting exists, so you can do for example:

.crazyvar__73737 > div > div{
&.avatarwrapper_526277{
display:none}
&.meow355{
  &.disabled{}
}

}

there's also :is(.class1, .class2), I'm bad at explaining so look there https://developer.mozilla.org/en-US/docs/Web/CSS/:is
but basically you can do

:is(#status, #account) .scroller .colordefault :is(> div, > div > div) {...}

also, I'm pretty sure that having a lot of selectors can impact performance, you don't need to target every single one in the tree, doing .crazyvar_666 .wrapper727 even though there's something between those 2 works as well

and please don't ask me why i have a trillion edits on this comment 💔

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Jul 3, 2024

Really good advice, thanks!

About the "selecting all selectors in the tree" thing, I tried to apply the effects to them individually using devtools to see which ones it was but it didn't work properly unless I applied it to all of them 💔

Also don't worry about the edit thing I've done the exact same thing in this very thread

Edit: I tried :is() first because it seemed to be the most straightforward and while I took a fair stab at it, it doesn't seem to work :(
image

@milbits
Copy link
Owner

milbits commented Jul 3, 2024

removing > div.. whatever lmao seems to fix it for me

:is(#status, #account) > .scrollerBase_c49869.none_c49869.scroller_d90b3d .colorDefault_d90b3d.labelContainer_d90b3d.item_d90b3d {
font-size: 14px;
min-height: 0px;
max-height: 28px;
}

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Jul 3, 2024

removing > div.. whatever lmao seems to fix it for me

:is(#status, #account) > .scrollerBase_c49869.none_c49869.scroller_d90b3d .colorDefault_d90b3d.labelContainer_d90b3d.item_d90b3d {
font-size: 14px;
min-height: 0px;
max-height: 28px;
}

cuts out the need to specify the repetitive divs entirely, quite nice
edit, noticed this implementation screws up the switch account menu, I think I need to find an applicable selector and then put it under a :not() element to fix that
image

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Jul 3, 2024

fixed it (i love pseudo selectors within pseudo selectors)
image

@milbits
Copy link
Owner

milbits commented Jul 3, 2024

#cat:not(.meow:has([aria-label="woof"]):not(:is(.brainrot,.rotbrain):has(.skibiditoilet)))

@KingGamingYT
Copy link
Collaborator Author

fixed the weird left padding in the accounts menu (it still exists in the status changer menu, but I don't care as much lol)
image
image

@milbits
Copy link
Owner

milbits commented Aug 16, 2024

image
i went on my alt and they moved the discover page to the bottom (and made it monochrome, fuck that black and white design trend) 💀

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Aug 16, 2024

went on my alt and they moved the discover page to the bottom (and made it monochrome, fuck that black and white design trend) 💀

Oh I got this yesterday, they made it fucking STICKY
I spent like 20 minutes trying to fix it to the bottom again and ended up giving up and just hiding it

never used the button anyway
arguably a more useless change than anything done to discord in the past two months because who do you know that actually frequently visits server discovery who didn't make their account 2 days afo

@milbits
Copy link
Owner

milbits commented Aug 16, 2024

well quests lie there now (not that i play 99% of the games)
image

@KingGamingYT
Copy link
Collaborator Author

that's awful

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Aug 16, 2024

ohhh THIS must be the experiment which does it
image
update: nope guess not, they're separate

@KingGamingYT
Copy link
Collaborator Author

image
image

@milbits
Copy link
Owner

milbits commented Aug 25, 2024

image
I HJATE THIS THING

image
made it sorta look good but im too lazy to make it fit better rn

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Aug 26, 2024

IT WORKS
image
image
theres still some bugs to work out (the partial clipping mentioned in the other issue, no blurple background, long statuses overflowing the menu (shown below), the two buttons still play their transition animation despite always being visible, and the fact that the custom status button is now above the regular status selector rather than below it, but it's a hell of a lot better than before and I'll come back to it tomorrow
image
(this has been by far one of the most frustrating things to work on I feel your pain)

@KingGamingYT
Copy link
Collaborator Author

i may be fucking stupid
image

@KingGamingYT
Copy link
Collaborator Author

my account lost the experiment that's odd

doesn't matter but still

@KingGamingYT
Copy link
Collaborator Author

I fixed the clipping when hovering over the bottom buttons :D

for some insane reason that I don't want to figure out I had to set the z-index on the add status button to FOUR
image

@KingGamingYT
Copy link
Collaborator Author

progress
image

@KingGamingYT
Copy link
Collaborator Author

it ain't perfect but eh it's something
image
image

@milbits
Copy link
Owner

milbits commented Sep 2, 2024

you need super lounging music to make it perfect

@KingGamingYT
Copy link
Collaborator Author

it would help if changing the dimensions of the hover background were easier, currently just to make it look like that its a hacky combination of width and block-size

@milbits
Copy link
Owner

milbits commented Sep 2, 2024

cant you just add a margin to the button and move the text a bit to the left (or something)

@KingGamingYT
Copy link
Collaborator Author

i'm pretty sure when I initially tried to do that it made positioning the text itself a pain because the "add status" text and the actual text of the status act differently but are affected in the same way

@milbits
Copy link
Owner

milbits commented Sep 2, 2024

nice

@KingGamingYT
Copy link
Collaborator Author

I tried it out and maaaaaaaybe if I'm super bored one day but this feels so grueling to accomplish at the moment I'm leaving it as is

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Sep 18, 2024

i'm gonna lose my mind
image
they removed all the icons what IS this

@KingGamingYT
Copy link
Collaborator Author

image
we're so back I hate it here

@milbits
Copy link
Owner

milbits commented Sep 18, 2024

i hate theming that thing
also if you played on future or past im afraid i must block you

@KingGamingYT
Copy link
Collaborator Author

i hate theming that thing

also if you played on future or past im afraid i must block you

my fellow present player
image

@milbits
Copy link
Owner

milbits commented Sep 18, 2024

just a 10x? bro i got 3 100x
2024091514281500-4CE9651EE88A979D41F24CE8D6EA1C23

@KingGamingYT
Copy link
Collaborator Author

I only got 10xes I never encountered a 100 or 333x 💀

@milbits
Copy link
Owner

milbits commented Sep 18, 2024

i wish I got a 333x

@KingGamingYT
Copy link
Collaborator Author

A friend of mine on past got like 4 😭

@milbits
Copy link
Owner

milbits commented Sep 18, 2024

HOW

@KingGamingYT
Copy link
Collaborator Author

KingGamingYT commented Sep 18, 2024

we're so back I hate it here

oh yeah I didn't even mention how discord broke the menu for those who don't have the enhanced status experiment yet (me) and the expander to select your status (online, offline, idle, dnd) is just gone
image
so I had to force the experiment on

@milbits
Copy link
Owner

milbits commented Sep 18, 2024

discord 🥰🥰❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants