Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose number of files option for logging SHM #9

Open
mileslucas opened this issue Mar 19, 2023 · 0 comments
Open

Expose number of files option for logging SHM #9

mileslucas opened this issue Mar 19, 2023 · 0 comments

Comments

@mileslucas
Copy link

mileslucas commented Mar 19, 2023

Long story short I'm looking for the option to log a SHM and have it automatically stop logging after N cubes. Lo and behold, the logic seems to already exist in the c-code, but the variable is not exposed in the function, and is not propagated into any of the downstream code that relies on this (e.g., milk-logshim, any of the camstack code, etc.).

https://github.com/milk-org/milk/blob/3457402c102fdaced7026e6e89108f55c2e4fe88/src/COREMOD_memory/logshmim.c#LL662C36-L662C36

I presume this would just work, but has it been tried before? This kind of option would be very good to use when designing the control software for the VAMPIRES upgrade, and I think it would improve certain aspects of the FastPDI workflow.

I think a good CLI would be

milk-logshim <shm> <nsub> [<ncubes>] <directory>

such that

milk-logshim apapane 1000 /media/data

would do what you expect and is backward-compatible while

milk-logshim apapane 1000 10 /media/data

would stop after 10 cubes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant