Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer or debounce file system reads to prevent overzelous pausing when under load #7

Open
mill1000 opened this issue Apr 28, 2020 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@mill1000
Copy link
Owner

The current approach of pausing the output after every failed read leads to stuttering playback on a loaded system, particularly if the filesystem is being taxed. In these cases we likely still have plenty of buffer between the DMA and read loop.

Instead we should either debounce the pause to only occur after a number of failed reads, or we should buffer the reads and only pause when the read buffer is exhausted.

Buffering has the side effect of adding additional latency but is easier to determine if we are at risk of underrun. Debouncing won't add any latency but underrun won't be as easy to detect.

@mill1000 mill1000 added bug Something isn't working enhancement New feature or request labels Apr 28, 2020
@mill1000 mill1000 self-assigned this Apr 28, 2020
@mill1000 mill1000 removed their assignment Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant