Skip to content

Commit 4533fc8

Browse files
authored
fix: [2.5] expression with capital AND and OR are not recognized (#38928)
fix #38864 AND, OR and NOT is not recognized in milvus parser master pr: #38927 Signed-off-by: Cai Zhang <[email protected]>
1 parent 5fb8313 commit 4533fc8

File tree

6 files changed

+315
-302
lines changed

6 files changed

+315
-302
lines changed

Makefile

+4
Original file line numberDiff line numberDiff line change
@@ -554,3 +554,7 @@ mmap-migration:
554554
mkdir -p $(INSTALL_PATH) && go env -w CGO_ENABLED="1" && \
555555
GO111MODULE=on $(GO) build -pgo=$(PGO_PATH)/default.pgo -ldflags="-r $${RPATH} -X '$(OBJPREFIX).BuildTags=$(BUILD_TAGS)' -X '$(OBJPREFIX).BuildTime=$(BUILD_TIME)' -X '$(OBJPREFIX).GitCommit=$(GIT_COMMIT)' -X '$(OBJPREFIX).GoVersion=$(GO_VERSION)'" \
556556
-tags dynamic -o $(INSTALL_PATH)/mmap-migration $(MMAP_MIGRATION_PATH)/main.go 1>/dev/null
557+
558+
generate-parser:
559+
@echo "Updating milvus expression parser"
560+
@(cd $(PWD)/internal/parser/planparserv2 && env bash generate.sh)

internal/parser/planparserv2/Plan.g4

+3-3
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ BAND: '&';
7171
BOR: '|';
7272
BXOR: '^';
7373

74-
AND: '&&' | 'and';
75-
OR: '||' | 'or';
74+
AND: '&&' | 'and' | 'AND';
75+
OR: '||' | 'or' | 'OR';
7676

7777
BNOT: '~';
78-
NOT: '!' | 'not';
78+
NOT: '!' | 'not' | 'NOT';
7979

8080
IN: 'in' | 'IN';
8181
EmptyArray: '[' (Whitespace | Newline)* ']';
+3-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
#!/usr/bin/env sh
22

3-
alias antlr4='java -Xmx500M -cp "../../../scripts/antlr-4.13.2-complete.jar:$CLASSPATH" org.antlr.v4.Tool'
3+
antlr4() {
4+
java -Xmx500M -cp "../../../scripts/antlr-4.13.2-complete.jar:$CLASSPATH" org.antlr.v4.Tool "$@"
5+
}
46
rm -fr generated
57
antlr4 -Dlanguage=Go -package planparserv2 -o generated -no-listener -visitor Plan.g4

internal/parser/planparserv2/generated/PlanLexer.interp

+1-1
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)