Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add workaround for concurrent tantivy reload and directory removal (#39441) #39472

Open
wants to merge 2 commits into
base: 2.4
Choose a base branch
from
Open

enhance: add workaround for concurrent tantivy reload and directory removal (#39441) #39472

wants to merge 2 commits into from
+12 −1

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 21, 2025

related pr: #39440
issue: #39428

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 21, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 21, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 21, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
fix code checker
a53300e 
Signed-off-by: sunby <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 21, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.42%. Comparing base (6111a0d) to head (a53300e).
Report is 33 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/core/src/storage/LocalChunkManager.cpp 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39472      +/-   ##
==========================================
+ Coverage   80.39%   80.42%   +0.02%     
==========================================
  Files        1080     1080              
  Lines      170087   170093       +6     
==========================================
+ Hits       136745   136792      +47     
+ Misses      28824    28791      -33     
+ Partials     4518     4510       -8
Files with missing lines Coverage Δ
internal/core/src/storage/LocalChunkManager.cpp 69.12% <57.14%> (-0.81%) ⬇️

... and 27 files with indirect coverage changes

@sunby
Copy link
Contributor Author

sunby commented Jan 22, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 22, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Feb 8, 2025

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 8, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

zhagnlu
zhagnlu reviewed Feb 12, 2025
View reviewed changes
internal/core/src/storage/LocalChunkManager.cpp
continue;
}
break;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not pure fix. removedir is common interface, for tantivy special case ,this retry should happens on caller.

@sunby
Copy link
Contributor Author

sunby commented Feb 13, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhagnlu zhagnlu zhagnlu left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees
No one assigned
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunby @sre-ci-robot @zhagnlu