Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: For the databases/drop_properties and databases/alter restful api, validation of illegal parameters is not performed #39545

Open
1 task done
zhuwenxing opened this issue Jan 23, 2025 · 4 comments
Assignees
Labels
feature/restful v2 kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@zhuwenxing
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:master
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

When setting invalid keys or values in properties, the interface does not report an error

However, setting invalid keys or values in index properties will result in an error

However, I believe this should be something that the Milvus kernel needs to handle. If the kernel does not implement validation, other SDKs will exhibit the same behavior


[2025-01-23 15:34:43 - DEBUG - urllib3.connectionpool]: http://10.104.21.108:19530 "POST /v2/vectordb/databases/drop_properties HTTP/1.1" 200 20 (connectionpool.py:475)
[2025-01-23 15:34:43 - DEBUG - ci_test]: 
method: post, 
url: http://10.104.21.108:19530/v2/vectordb/databases/drop_properties, 
cost time: 0.08727908134460449, 
header: {'Content-Type': 'application/json', 'Authorization': 'Bearer None'}, 
payload: {
    "dbName": "test_drop_props_nonexistent",
    "propertyKeys": [
        "nonexistent.key"
    ]
}, 
response: {"code":0,"data":{}} (milvus.py:80)
[2025-01-23 15:36:26 - DEBUG - urllib3.connectionpool]: http://10.104.21.108:19530 "POST /v2/vectordb/databases/alter HTTP/1.1" 200 20 (connectionpool.py:475)
[2025-01-23 15:36:26 - DEBUG - ci_test]: 
method: post, 
url: http://10.104.21.108:19530/v2/vectordb/databases/alter, 
cost time: 0.0834190845489502, 
header: {'Content-Type': 'application/json', 'Authorization': 'Bearer None'}, 
payload: {
    "dbName": "test_alter_props_invalid",
    "properties": {
        "invalid_key": true
    }
}, 
response: {"code":0,"data":{}} (milvus.py:80)
[2025-01-23 15:36:26 - DEBUG - urllib3.connectionpool]: http://10.104.21.108:19530 "POST /v2/vectordb/databases/alter HTTP/1.1" 200 20 (connectionpool.py:475)
[2025-01-23 15:36:26 - DEBUG - ci_test]: 
method: post, 
url: http://10.104.21.108:19530/v2/vectordb/databases/alter, 
cost time: 0.09098601341247559, 
header: {'Content-Type': 'application/json', 'Authorization': 'Bearer None'}, 
payload: {
    "dbName": "test_alter_props_invalid",
    "properties": {
        "mmap.enabled": "invalid_value"
    }
}, 
response: {"code":0,"data":{}} (milvus.py:80)

Expected Behavior

No response

Steps To Reproduce

Milvus Log

No response

Anything else?

No response

@zhuwenxing zhuwenxing added kind/bug Issues or changes related a bug needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 23, 2025
@yanliang567 yanliang567 added this to the 2.5.5 milestone Jan 24, 2025
@yanliang567 yanliang567 added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 24, 2025
@yanliang567
Copy link
Contributor

/unassign

@smellthemoon
Copy link
Contributor

as designed. When drop/alter not existed properties, will not throw err.

@smellthemoon
Copy link
Contributor

/assign @zhuwenxing

@smellthemoon
Copy link
Contributor

/unassign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/restful v2 kind/bug Issues or changes related a bug triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants