Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Rename FLOAT16_VECTOR and BFLOAT16_VECTOR #2610

Open
1 task done
cydrain opened this issue Feb 6, 2025 · 2 comments
Open
1 task done

[Enhancement]: Rename FLOAT16_VECTOR and BFLOAT16_VECTOR #2610

cydrain opened this issue Feb 6, 2025 · 2 comments
Assignees
@XuanYang-cn
Labels
kind/enhancement New feature or request
Milestone
2.4.15

Comments

@cydrain
Copy link
Contributor

cydrain commented Feb 6, 2025 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Rename FLOAT16_VECTOR to Float16Vector, and BFLOAT16_VECTOR to Bfloat16Vector to sync naming style with others

Image

Why is this needed?

No response

Anything else?

No response
@cydrain cydrain added the kind/enhancement New feature or request label Feb 6, 2025
@cydrain
Copy link
Contributor Author

cydrain commented Feb 6, 2025

/assign @XuanYang-cn

@XuanYang-cn XuanYang-cn added this to the 2.4.15 milestone Feb 6, 2025
@XuanYang-cn
Copy link
Contributor

Maybe juse use proto's placeholder type enum and deprecate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XuanYang-cn XuanYang-cn

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
2.4.15
Development

No branches or pull requests
2 participants
@cydrain @XuanYang-cn