Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adds linear regression example #28

Merged
merged 6 commits into from
Nov 17, 2023
Merged

docs: adds linear regression example #28

merged 6 commits into from
Nov 17, 2023

Conversation

grzuy
Copy link
Collaborator

@grzuy grzuy commented Nov 14, 2023

No description provided.

@grzuy grzuy force-pushed the examples branch 2 times, most recently from 980eb63 to 5d1c912 Compare November 14, 2023 18:07
mode = if Mix.env() in [:dev, :test], do: :debug, else: :release
# Test with release mode temporarily
# mode = if Mix.env() in [:dev, :test], do: :debug, else: :release
mode = :release
Copy link
Collaborator Author

@grzuy grzuy Nov 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently the failure attempt to add with overflow (https://github.com/mimiquate/candlex/actions/runs/6867701290/job/18676632218) in first commit is gone if cargo run on release mode instead of debug.

Need to dug deeper to understand what's causing the error in debug mode.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems there's a u32 addition of 3131444833 + 4143857739 causing the panic because of the attempt to add with overflow.
Coming from Nx.Random.normal call in first call to init random params.

Copy link
Collaborator Author

@grzuy grzuy Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Narrowed it down to a problem when calculating the next random key, which I think actually expects overflow at u32 without that being a problem.
Planning to open separate PR with test and fixes for that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an actual bug in Nx.Random.
#32.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#32 merged into main.

Now updated this PR with main.

@grzuy grzuy marked this pull request as ready for review November 17, 2023 17:50
@grzuy grzuy merged commit df12347 into main Nov 17, 2023
4 checks passed
@grzuy grzuy deleted the examples branch November 17, 2023 18:39
xabi pushed a commit to xabi/candlex that referenced this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant