-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: adds linear regression example #28
Conversation
980eb63
to
5d1c912
Compare
lib/candlex/native.ex
Outdated
mode = if Mix.env() in [:dev, :test], do: :debug, else: :release | ||
# Test with release mode temporarily | ||
# mode = if Mix.env() in [:dev, :test], do: :debug, else: :release | ||
mode = :release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the failure attempt to add with overflow
(https://github.com/mimiquate/candlex/actions/runs/6867701290/job/18676632218) in first commit is gone if cargo
run on release mode instead of debug.
Need to dug deeper to understand what's causing the error in debug mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there's a u32 addition of 3131444833 + 4143857739
causing the panic because of the attempt to add with overflow
.
Coming from Nx.Random.normal
call in first call to init random params.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Narrowed it down to a problem when calculating the next random key, which I think actually expects overflow at u32 without that being a problem.
Planning to open separate PR with test and fixes for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an actual bug in Nx.Random
.
#32.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#32 merged into main
.
Now updated this PR with main
.
No description provided.