-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mbx 0000 snackbar new way #269
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
70ff749
MBX-0000 New way
338df1d
MBX-0000 New way 2
23426d8
MBX-0000 New way 3
e8051a2
MBX-0000 Custom window
b4c9993
MBX-0000 Snackbar Custom Window
103b91e
MBX-0000 New way
670a3d0
MBX-0000 New way 2
6a5363d
MBX-0000 New way 3
3843e35
MBX-0000 Custom window
74acb1a
MBX-0000 Snackbar Custom Window
6810425
Merge remote-tracking branch 'origin/feature/MBX-0000-snackbar-new-wa…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,17 +7,19 @@ | |
// | ||
|
||
import UIKit | ||
import MindboxLogger | ||
|
||
class ImageLayerFactory: LayerFactory { | ||
func create(from image: UIImage, layer: ContentBackgroundLayer, in view: UIView, with controller: GestureHandler) -> UIView? { | ||
if case .image(let imageContentBackgroundLayer) = layer { | ||
let inAppView = InAppImageOnlyView(image: image, action: imageContentBackgroundLayer.action) | ||
let imageTapGestureRecognizer = UITapGestureRecognizer(target: controller, action: #selector(controller.imageTapped(_:))) | ||
inAppView.addGestureRecognizer(imageTapGestureRecognizer) | ||
|
||
Logger.common(message: "ImageLayerFactory return uiView.") | ||
return inAppView | ||
} | ||
|
||
|
||
Logger.common(message: "ImageLayerFactory return nil.") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. а почему это common а не варнинг какой нибудь? |
||
return nil | ||
} | ||
|
||
|
@@ -39,5 +41,6 @@ class ImageLayerFactory: LayerFactory { | |
view.leadingAnchor.constraint(equalTo: parentView.leadingAnchor), | ||
view.trailingAnchor.constraint(equalTo: parentView.trailingAnchor) | ||
]) | ||
Logger.common(message: "ImageLayerFactory setupConstraintsSnackbar finished.") | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.normal + 3
Ты хоть бы вынес куда нибудь эту цифру