Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove to_tree method from AST classes #310

Open
ea-rus opened this issue Sep 21, 2023 · 2 comments
Open

Remove to_tree method from AST classes #310

ea-rus opened this issue Sep 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@ea-rus
Copy link
Contributor

ea-rus commented Sep 21, 2023

Do we use to_tree method for any purpose?

For now it is additional code in every ASTNode class which looks like is not used

@tomhuds tomhuds added the enhancement New feature or request label Sep 27, 2023
@BattiniSandeep
Copy link

Hey hii. I would like to work on this issue.

i have gone through the code, I saw that we are to_tree a lot in test cases, If we remove to_tree method, then most of the test cases would get affected.

so little confused what to do next, do you still want me to remove to_tree method?

Thank you, Sandeep Kumar

@ea-rus
Copy link
Contributor Author

ea-rus commented Oct 13, 2023

Hey, I think we can remove to_tree in tests too. Don't check result of this method if it don't exist anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants