Torch Fire protect bug

[KollinsPlays]

It's been a few weeks, but at some point after an update to 3D Armor from ContentDB, armor stopped protecting the player from torch damage.

name = 3d_armor
title = 3D Armor
description = Visible player armor & wielded items.
release = 16954
author = stu

Minetest 5.7.0 x64 portable

These options exist in the mod's settings:

# Enable fire protection (defaults true if using ethereal mod).
armor_fire_protect (Enable fire protection) bool false

# Enable fire damage from torches (defaults true if using ethereal mod).
armor_fire_protect_torch (Enable fire protection torch damage) bool false

I have tried setting fire damage from torches to both true and false, but with either setting, players still take damage from torches. I have tested in my existing modded world, but was able to recreate this bug in a new world with only the 3D Armor mod.

In addition to losing the ability to turn off this damage, the [English translation?] wording of this setting is ambiguous. The setting for fire protection seems to mean if true, protect from fire and if false, don't protect from fire. The torches setting seems to mean the opposite, in that true doesn't protect and false does protect. I suggest that the wording of these 2 settings be changed so that both states match and the wording is less ambiguous:

# Enable fire protection (defaults true if using ethereal mod. **True means armor protects from fire**).
armor_fire_protect (Enable fire protection) bool false

# Enable fire **protection** from torches (defaults false if using ethereal mod. **True means armor protects from torches**).
armor_fire_protect_torch (Enable **torch damage protection**.) bool true

Also, from a roleplay perspective and reality v.s. game mechanics, it sort of makes sense to take fire damage if you are standing in say fire or lava, but in reality any person standing in the same 1 cubic meter area as a torch would instinctually be able to share that space with a torch while avoiding being so close to burn themselves. If I walked by a torch on the floor or wall of a narrow hallway, I wouldn't even have to think about it to avoid burning myself by the torch as I stood next to it.

[Nordall]

The comment in 3d_armor/init.lua line 71 is misleading. Instead of "damage" it should say "protect". Fire protect works, but torch protect and water protect not. On v5.6.1. The armor config file is missing water protect configuration.

[Niklp09]

changed/introduced in dc7fbce

[Nordall]

If I understand right, it is intended that torch fire protect does not work if fire protect is enabled.