Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gloves and Gauntlets #108

Open
sirrobzeroone opened this issue Jul 15, 2023 · 4 comments
Open

Gloves and Gauntlets #108

sirrobzeroone opened this issue Jul 15, 2023 · 4 comments
Labels
discussion question Further information is requested

Comments

@sirrobzeroone
Copy link

Before I roll onto content_db and clutter it up, would it be better if I rolled my glove/gauntlet into the main 3d_Armor baseas a pull request.

I'm thinking similar to shields but unlike shields off by default. Also understand if its better to leave it as a seperate mod as it will add more maintenace overhead for 3d_Armor.

I'm happy with either outcome just wanted to make the offer.

@BuckarooBanzay BuckarooBanzay added the enhancement New feature or request label Jul 16, 2023
@BuckarooBanzay
Copy link
Member

Before I roll onto content_db and clutter it up, would it be better if I rolled my glove/gauntlet into the main 3d_Armor baseas a pull request.

IMO: the 3d_armor should be broken up anyway into api, shield and armor types (i currently don't have the energy or time to discuss and implement that though) @SmallJoker your opinion on that, maybe i'll plan something someday

And: why do you think it will clutter up the cdb?

Also understand if its better to leave it as a seperate mod as it will add more maintenance overhead for 3d_Armor.

The maintenance thing wouldn't be my concern, but we have now a contentdb with dependency resolution, gui and everything and we should use that (my opinion, not the creator of this mod)
There's also the possibility to add maintainers on cdb if you think you are going to be unresponsive for a longer time.

I'm happy to help if you need assistance with git/cdb or anything in that direction.

@BuckarooBanzay BuckarooBanzay added question Further information is requested discussion and removed enhancement New feature or request labels Jul 16, 2023
@BuckarooBanzay BuckarooBanzay changed the title Gloves and Gauntlets [discussion/question] Gloves and Gauntlets Jul 16, 2023
@sirrobzeroone
Copy link
Author

Sounds like the plan is more smaller modules if able in the future, more like a main api and then config mods. Clutters probably not the right word for CDB, was more thinking for new players hard to find all the different parts.

Not planning on going anywhere, I do go quiet when works busy but otherwise I'll be about. Good Idea on the maintainers though.

@SmallJoker
Copy link
Member

3d_armor is already a modpack where individual components can be enabled or disabled on demand. If you think that it fits best into this repository, that's fine by me. Alternatively you could publish a separate mod and depend on 3d_armor (which might need API changes). The benefit from that would be that there's no review process like in 3d_armor, hence more liberty to add whatever you'd like.

@mckaygerhard
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants