Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some recipes using groups with no match still show the group as an unknown item #242

Open
fluxionary opened this issue Jan 4, 2024 · 5 comments
Labels

Comments

@fluxionary
Copy link

the fix for #218 (#223) apparently doesn't solve the problem for all recipes, though it does fix the recipe in that issue, which i was using for testing. in particular, the recipes from the beacons mod still have issues:

local color = "red" -- example
local color_group = "excolor_" .. color

minetest.register_craft({
	output = "beacons:base_" .. color,
	recipe = {
		{"default:steel_ingot", "group:" .. color_group, "default:steel_ingot",},
		{"default:steel_ingot",      "default:meselamp", "default:steel_ingot",},
		{"default:steel_ingot",   "default:steel_ingot", "default:steel_ingot",},
	},
})

minetest.register_craft({
	type = "shapeless",
	output = "beacons:base_" .. color,
	recipe = {"group:beacon_base", "group:" .. color_group},
})

image

image

@SmallJoker
Copy link
Member

SmallJoker commented Jan 5, 2024

#223 addresses the ingredient lookup when using the "copy to craft grid" functionality and possibly also the group filter in the craft recipe upon click.

I assume those functions still work properly and the group simply lacks a proper icon in the guide?

@fluxionary
Copy link
Author

#223 addresses the ingredient lookup when using the "copy to craft grid" functionality and possibly also the group filter in the craft recipe upon click.

i haven't dug into the cause, but the problem still exists when i'm using that commit or the most recent commit.

@fluxionary
Copy link
Author

replication should just be using minetest game with the beacons mod and unified_inventory installed

@SmallJoker
Copy link
Member

SmallJoker commented Jan 6, 2024

@fluxionary Which mod provides dyes with the group excolor_* ?

A few years ago excolor_* was removed from the MTG dyes. Wuzzy already complained about that: minetest/minetest_game#2203

@fluxionary
Copy link
Author

fluxionary commented Jan 7, 2024

Which mod provides dyes with the group excolor_*

none that i know of. the expected behavior if there isn't a match should be to not show the recipe, i think.

@SmallJoker SmallJoker added the Bug label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants