-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why not properly license whynot? :-D #134
Comments
On this topic @bell07 why is it GPL3 only, instead of GPL3 or later as per standard convention? |
There is no reason. I am not license expert, was sure the statement in README.md is enough for the project.
Please change it as needed. |
So to be perfectly clear, for "legal reasons" as it were, @bell07 @dacmot Are you alright if I change the licence to And for the record, "no" is a perfectly OK and reasonable answer. |
I'm absolutely for GPLv3 and later. I have noticed the lack of licenses or the use of LGPLv2.1 in whynot_compat... If you're up for it, please fix it and make it consistent. Thanks! |
I'll just do a PR to add the licence as is. Also, backlinking to https://content.minetest.net/threads/3398/ so I can find it later. |
wow, you are fast folks!
about compatible licenses with GPLV2 and GPLV3 only adding the licensing is a first step, but not the only one! |
Not sure about the artwork. Each mod will have licenses for their own artwork. The only art for Why Not? Game are the crumpled ball logo, and the screenshots. I don't know where screenshots fall legally: is it Minetest? Is it the mod's in-game art showcased? Is it our capture (like a photograph)? IANAL and don't have the knowledge to determine. |
For the copyright holders, would a statement like what Minetest does be OK?
It does have a good point that git keeps track of all that information much better than any human could by updating the copyright notice. |
Technically, the GPLv3 header is optional. Undecided as of yet if I like the idea of doing it for this project. Here's the count of each code licence used by the mods in this project, and the number of instances:
I am fully aware of some of the "duplicates" but I distinguished any that could reasonably be held to be different by any court of law.
I found that most of the homdecor mods do not have their licence information attached anymore in the built directory. we do actually need to fix that. Here are the 108 mods where the code licence is not readily apparent, whether by our fault, or the developers fault
This post took more than 1.5 hours to write, was done by hand, and is likely full of errors. |
That's incredible. Thank you. |
Cool!
well, theoretically it's not optional, non copyleft licenses as Apache2 are easier to accomplished, as they don't need a license header, but if you want to register a GPL licensed app in the GNU portal (GNU Savannah), for example, it will be mandatory. But yes, my help is giving the correct information about licensing, but you, of course, can achieve the licensing level you want to achieve.
remember, Unlicense or not license is considered legally closed source software and incompatible, we need everything explicitly licensed.
good work! :-O |
The "Unlicence" licence has actual license text, akin to the MIT license. The repo isn't saying it doesn't have a license, it's saying it's using a license of that name |
I pushed some fixes to the build scripts in order to copy the license file from modpacks to each individual mod. That seems to have fixed many of the missing licenses found by Lazerbeak12345. After that, I looked at the remaining ones:
I will create issues with each repository to ask for them to add a license file. |
Thanks dacmot! |
A note: we might need a new rule to prevent further licence shenanigans. |
I was just thinking the same thing. Rule 10: The code and artwork must be licensed with terms compatible with GPLv3 (see https://www.gnu.org/licenses/license-list.en.html#GPLCompatibleLicenses), and with copyrights attributed to the rightful author(s). Not sure about the second bit. I guess some licenses may forgo copyrights (public domain)... |
On the note about public domain: Some countries don't recognize public domain as an option. They treat works put under public domain as they would unlicenced code. This is why the CC licence puts things under public domain, with a fallback to a permissive licence. All in all, we would be forced to consider public domain as closed source to ensure it works with our software, regardless of which licence we choose. |
Toolranks is done! |
I updated the OP to make this issue more actionable. I'm sure I missed stuff, and I'm not sure exactly what conflicts need to be resolved. Please add more information as it is found. |
Do we need to do anything about the mod making use of the |
If I read this correctly (IANAL), it should be fine as long as we remain GPLv3-only:
I guess we may have to fork it and relicense it?? I don't know if it's possible to include as-is. |
from FSF: |
Please correct me if I'm wrong, but the way I understand it, this two step process is only if we want to relicense to GPLv3+ (emphasis on the +). The license would allow usage as-is as part of a GPLv3-only. See EUPL V1.2 terms
(Emphasis mine). And,
|
So, (and also IANAL) that looks like we can just treat this software as a GPLv3, for now. Likely we won't be moving to GPLv3 or later anytime soon. GPLv3 only seems to be what we are stuck with. |
So with that... are we good? Are all licence conflicts resolved? |
I think there's the two without licenses in the source code left, and a couple others that are GPLv2-only (not upgradable)... if I understand correctly. |
I've posted on the forumn and made a PR for engrave. We could use my fork on that branch in the pr for now. |
Nice! great work! I'm not sure what, from a legal perspective, is and isn't allowed in a "Clean Room Design," so I'm unsure as to the degree I or any other developer we've reached out to would be able to make a new helicopter mod. |
Yeah. Well, at the very least, if Pavel answers we should be able to include it as GPLv2 or any later version. I found an email address and tried to reach him directly, in case he doesn't get notifications from Github anymore. Hopefully we get an answer... eventually :) |
Hmmm... email is bouncing :( that might also explain why he's not very responsive to stuff happening on Github... |
As posted on the related sub-issue, I've attempted to reach Pavel through the forum. Pavel was "Last active:Sat Jan 16, 2021 02:22". That was 649 days ago from today. If we assume that's the period that Pavel sees forum notifications, then we will have to wait till "Tuesday, August 6, 2024" - and I don't think that waiting that long is an option. |
I also checked to see if Pavel has a discord account and is in the Minetest Discord. There is a Pavel - but different last name. |
Yeah, I have the feeling he's gone, done, moved on from minetest. Given how long ago he's visited the forums I doubt he'll be back. I think Github may have more chance of grabbing his attention, even if his last activity was May 2022. I checked Gitlab, codeberg and notabug too just in case... turns out his name is fairly common :-/ I couldn't tell if he has another account in any of those places. In any case, I think we may have to remove the helicopter mod for the time being. It'll break compatibility, but I feel like we don't have much choice. |
We had to remove this mod because of legal issues. See also #134
All noted incompatibilities have been addressed. |
Not quite. Still missing |
Right. That still needs done. I was just referencing that all mods with incompatible licences have been fixed in one way or another. |
Actually, we haven't reviewed the image licences. I have no idea how it works at all. While I've read the full license text for all of the relevant code licenses and know of resources to double-check my assumptions and understandings of the code licences, I can't say the same for image licences. I know we do need an expressly granted right to redistribute but I don't know what else we need for this project. |
I don't find a link anywhere :-/ What I can say is what I needed to do for publishing projects in the GNU Portal, Savannah, in the past. The media content, must be specified in a README in it's folder, and in the main README, with a image, sound, video, filenames list in it, it's copyright and license for every one. If other license has been chosen for them, for example, CC-BY, it's legal text must be added to the project root folder also. I had to to this:
:-/ |
I'd guess then, akin to my list of code licences in use, we need a count of what media licences are in use. We can then evaluate from there next steps. |
Yeah... Probably. |
I was going through but there's a few edge cases I don't know if works. I guess we could just assume any mod that doesn't define the licence for at least a portion of the media is putting the licence under the code licence. And from my digging, here's the types of media I found:
Did I miss anything? |
Would screenshots fall into textures? Are they copyrightable? |
Ah missed that. And that's a good question. I'd argue there's "Fair use" involved there. So perhaps, but perhaps not? |
From other use around screenshots, it seems that screenshots are a derivative work - if not a complete copy. The way we use them, I'd say derivative, seeing as they are composed of the other assets used in the game. |
The result of As before, it might be best to go on a mod-by-mod basis. |
Licence unknown
Credit given, media licence not specifiedAll media within
Textures are specified, but does this qualify?
|
Problem: The flyingcarpet mod says:
They actually are wrong.... |
issue made upstream Amaz1/flight#2 |
I think it might be time to take decisions on flyingcarpet and engrave. Neither ones have responded to requests to properly license their mods. Looking at their github accounts, they are not active at all and will likely never respond. In both cases, we could fork them and add the proper licenses ourselves. Flying carpet is based on helicopter which is GPLv2 or later, and engrave is LPGL v2.1 according to the forums. I think that would be preferable to removing the mods. What do you think? |
Compared to Apercy's modern flight mods, carpet is very low quality. It functions nearly identical to the upstream helicopter, and like that mod doesn't limit flight in any way. My players on my server moved to it from Pavel's heli, and many prefer it over the faster but more limited hydroplane |
So it feels like cheating :) I agree. Though that should probably be addressed in a separate issue. |
Hi!
Your game is licensed under GPLv3 only in the minetest contendb page, but I see the code here unlicensed!
I you want, if you are interested, I can help
the basic guidelines from the FSF can be found here
cheers and happy hacking
Section made by @Lazerbeak12345 in order to make this issue actionable
The text was updated successfully, but these errors were encountered: