Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod Request]: drawers Storage Drawers #153

Open
1 task
Lazerbeak12345 opened this issue Feb 10, 2023 · 3 comments
Open
1 task

[Mod Request]: drawers Storage Drawers #153

Lazerbeak12345 opened this issue Feb 10, 2023 · 3 comments
Assignees
Labels
new-mod-proposal Consider the mod can be applied to the game

Comments

@Lazerbeak12345
Copy link
Collaborator

Lazerbeak12345 commented Feb 10, 2023

Request

This is the URL for the mod I would like to be added:

https://content.minetest.net/packages/LNJ/drawers/

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • None
  2. When could this mod be a strain on the server when no players are using the mod?
    *
  3. When does this mod destroy player's work?
    • never
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    *
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    • None.
  6. Is this mod survival friendly? What items that it provides that should be craftable/obtainable, but arent?
    • it's very well balanced. Upgrades cost resources.
  7. When does this mod feel like cheating?
    • never
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specifically needed, although these do qualify).
    • Yes
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    • By design it doesn't accept unstackables. This can be confusing.
  10. Is the licence one that we can include in WhyNot? (Whynot is under the GPLv3 only. Be sure you know what you are talking about or cite your source)
  • Yes. "Code & Textures are MIT, Translations are CC0 1.0." from Forum post

Other comments

Requested by a user of my private WhyNot server.


  • make PR for code review
@Lazerbeak12345 Lazerbeak12345 added the new-mod-proposal Consider the mod can be applied to the game label Feb 10, 2023
@github-project-automation github-project-automation bot moved this to Basic research questions (licence, etc) in Add New Game Content Feb 10, 2023
@Lazerbeak12345 Lazerbeak12345 moved this from Basic research questions (licence, etc) to Code Review in Add New Game Content Feb 10, 2023
@Lazerbeak12345 Lazerbeak12345 moved this from Code Review to Playtest in Add New Game Content Feb 10, 2023
@dacmot
Copy link
Collaborator

dacmot commented Feb 26, 2023

Sounds like a neat thing.

@Lazerbeak12345
Copy link
Collaborator Author

Playtest concerns

  • Not a show-stopper, but it doesn't have any sort of locking mechanism to keep other users out.
  • Homedecor has drawers too, but those are more or less just chests with a different model. They don't integrate.

I think there's nothing to worry about on the playtest side of things.

@Lazerbeak12345 Lazerbeak12345 moved this from 1 Playtest to 2 Code Review in Add New Game Content Sep 16, 2023
@Lazerbeak12345
Copy link
Collaborator Author

Updated OP with notes from playtest

@dacmot dacmot self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-mod-proposal Consider the mod can be applied to the game
Projects
Status: 2 Code Review
Development

No branches or pull requests

2 participants