Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mod Request]: randungeon #158

Open
Lazerbeak12345 opened this issue Jul 30, 2023 · 6 comments
Open

[Mod Request]: randungeon #158

Lazerbeak12345 opened this issue Jul 30, 2023 · 6 comments
Labels
mapgen New mod proposal affects mapgen new-mod-proposal Consider the mod can be applied to the game

Comments

@Lazerbeak12345
Copy link
Collaborator

Lazerbeak12345 commented Jul 30, 2023

Request

This is the URL for the mod I would like to be added:

https://github.com/phseiff/randungeon

My opinion on how it fits with the whynot rules:

Refer to the Whynot Readme for full rule descriptions/reasons.

  1. In what ways might this mod take over the game?
    • Adds a lot of content? Not sure if it counts.
    • Worldgen related - but it's very configurable.
  2. When could this mod be a strain on the server when no players are using the mod?
    • Only runs when requested, or during gen. Never.
  3. When does this mod destroy player's work?
    • Only upon admin account request it can generated dungeons on the fly in arbitrary locations. Unsure as to what level of control this mod gives to prevent work destruction. TODO
  4. Have you looked at the code? If so, what stood out as things that might need fixing?
    *
  5. In what way might this mod be reduced to be more simple (as in "Keep it Simple Stupid") (ex: "the foobar mod could be made more simple by splitting into two mods, foo and bar")
    *
  6. Is this mod survival friendly? What items that it provides that should be craftable/obtainable, but arent?
    • Does provide materials that might be a bit more on the rare side of things - but I don't think it's enough to cause problems.
  7. When does this mod feel like cheating?
    • Only if something high value? Not sure. Playtest needed. Seems designed to prevent this.
  8. Does this mod use the software "git" for version control? (note: we are asking about git. Github, Gitlab, notabug and hundreds of other git providers exist but are not specificly needed, although these do qualify).
    • Yes.
  9. Upon testing this mod, what errors, odd behavior, or other incompatibilities were noticed?
    *
  10. Is the licence one that we can include in WhyNot? (Whynot is under the GPLv3 only. Be sure you know what you are talking about or cite your source)
  • AGPLv3 for code
  • CC by SA 3 for media

Other comments

There's virtually nothing in the world. This can help with that.

@Lazerbeak12345 Lazerbeak12345 added the new-mod-proposal Consider the mod can be applied to the game label Jul 30, 2023
@github-project-automation github-project-automation bot moved this to 0 Basic research questions (licence, etc) in Add New Game Content Jul 30, 2023
@Lazerbeak12345
Copy link
Collaborator Author

Please note that the GNU AGPL is not compatible with GPLv2.

https://www.gnu.org/licenses/license-list.html#AGPLv3.0

Whynot is under GPLv2.

However, you are allowed to combine separate modules or source files released under both of those licenses in a single project, which will provide many programmers with all the permission they need to make the programs they want. See section 13 of both licenses for details.

From Section 13 of AGPLv3

Notwithstanding any other provision of this License, you have permission to link or combine any covered work with a work licensed under version 3 of the GNU General Public License into a single combined work, and to convey the resulting work. The terms of this License will continue to apply to the part which is the covered work, but the work with which it is combined will remain governed by version 3 of the GNU General Public License.

If we upgrade to GPLv2 or later, then take the later route, this is a mod we will gain

@Lazerbeak12345 Lazerbeak12345 moved this from 0 Basic research questions (licence, etc) to Rejected in Add New Game Content Aug 6, 2023
@Lazerbeak12345 Lazerbeak12345 added breaks-rule10 This code or artwork is not under a compatible licence and removed breaks-rule10 This code or artwork is not under a compatible licence labels Aug 6, 2023
@Lazerbeak12345 Lazerbeak12345 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 6, 2023
@Lazerbeak12345 Lazerbeak12345 reopened this Aug 6, 2023
@github-project-automation github-project-automation bot moved this from Rejected to 0 Basic research questions (licence, etc) in Add New Game Content Aug 6, 2023
@Lazerbeak12345
Copy link
Collaborator Author

I actually appear to be wrong about that. I got things mixed up somehow. WhyNot is GPLv3, so it looks like this might be fine.

@Lazerbeak12345 Lazerbeak12345 removed the breaks-rule10 This code or artwork is not under a compatible licence label Aug 6, 2023
@Lazerbeak12345
Copy link
Collaborator Author

Because our code is hosted publicly (here), we are compatible with this licence.

  1. Use with the GNU Affero General Public License.
    Notwithstanding any other provision of this License, you have permission to link or combine any covered work with a work licensed under version 3 of the GNU Affero General Public License into a single combined work, and to convey the resulting work. The terms of this License will continue to apply to the part which is the covered work, but the special requirements of the GNU Affero General Public License, section 13, concerning interaction through a network will apply to the combination as such.

@Lazerbeak12345 Lazerbeak12345 moved this from 0 Basic research questions (licence, etc) to 1 Playtest in Add New Game Content Aug 6, 2023
@bell07
Copy link
Collaborator

bell07 commented Aug 6, 2023

whynot is GPL3. See readme.md

@Lazerbeak12345 Lazerbeak12345 added the mapgen New mod proposal affects mapgen label Aug 6, 2023
@Lazerbeak12345
Copy link
Collaborator Author

That referenced issue was a duplicate

@Lazerbeak12345
Copy link
Collaborator Author

Merged duplicates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mapgen New mod proposal affects mapgen new-mod-proposal Consider the mod can be applied to the game
Projects
Status: 1 Playtest
Development

No branches or pull requests

2 participants