Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laptop mod repository is gone #190

Open
dacmot opened this issue Mar 30, 2024 · 7 comments
Open

Laptop mod repository is gone #190

dacmot opened this issue Mar 30, 2024 · 7 comments
Assignees
Labels
Mod or fork replacement Proposal to replace a mod in Whynot by alternative

Comments

@dacmot
Copy link
Collaborator

dacmot commented Mar 30, 2024

Problem

Laptop mod repository is gone from github. The whole account https://github.com/Gerold55 doesn't exist anymore.

Steps to reproduce

Fetching all submodules caused an error "remote: Repository not found."

Expected behavior

The laptop repository to be available?

Minetest client version

5.6.8

WhyNot? Game version

2024-03-14

Operating system/version

Ubuntu 22.04

Installation

Build scripts

Additional mods enabled in your world (ex. technics, mobs_animals, etc.)

none

@dacmot dacmot added bug Something isn't working prio-high Issue should be solved as soon as possible labels Mar 30, 2024
@dacmot dacmot self-assigned this Mar 30, 2024
@dacmot
Copy link
Collaborator Author

dacmot commented Mar 30, 2024

Another mod to fork I guess...

@dacmot
Copy link
Collaborator Author

dacmot commented Mar 30, 2024

@dacmot dacmot closed this as completed Mar 30, 2024
@bell07
Copy link
Collaborator

bell07 commented Apr 2, 2024

I am the main developer for Lua-site of the mod. Wrote the Laptop-OS and the most apps. Gerold part is the models, textures and organizational tasks.
If Gerold is giving up the mod, from my point of view the mod should be moved into any maintenance organization like "minetest-mods".

My fork https://github.com/bell07/minetest-laptop is still there, so I can trigger the transfer into organization if you agree.
Of course I will continue to support the mod in case of issues in any case.

The difference in my fork and the Gerolds version is: I did not merged the "browser_app" into master, because of incomplete from my point of view.
I did not looked into the mod for times, therefore maybe my fork needs to be updated first, before transfer

@dacmot
Copy link
Collaborator Author

dacmot commented Apr 3, 2024

That's a better idea. I agree that adding it to minetest-mods would be the best solution.

@dacmot dacmot reopened this Apr 3, 2024
@dacmot
Copy link
Collaborator Author

dacmot commented Apr 3, 2024

Hmmm. https://github.com/Gerold55 is back...

@dacmot dacmot added Mod or fork replacement Proposal to replace a mod in Whynot by alternative and removed prio-high Issue should be solved as soon as possible bug Something isn't working labels Apr 3, 2024
@dacmot
Copy link
Collaborator Author

dacmot commented Jun 8, 2024

@bell07 just a reminder, when you have the time (no rush), would you please review/update your fork and transfer the ownership to minetest-mods? Thanks!

@bell07
Copy link
Collaborator

bell07 commented Jun 9, 2024

I compared both forks. All my last changes are all in Gerold55 version. But the current Gerold version contains more features:

  • Browser App (my initial development)
  • Painting App (by sfence)
  • Power supply by technic mod / battery (by sfence)

Maybe better idea is to use Gerold version and add some additional Whnot related web-pages (The rules for example) using Browser app (laptop.register_view(browser_page = true), see API.md)

I think it is better if @Gerold55 transfer his Fork into mintest-mods.
@Gerold55, what do you think? I cannot support you anymore in lua, since I am away from Minetest. the mintest-mods group have experienced developers (like sfence) that can support you in case of lua related issues.

By the way, did anyone of you experienced this issue: Gerold55/laptop#146
I tried it shortly, and cannot get the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod or fork replacement Proposal to replace a mod in Whynot by alternative
Projects
None yet
Development

No branches or pull requests

2 participants