Whynot Team building

[bell07]

Started discussion at #42 (comment) moved to this thread

@bell07
Unfortunately I am away from minetest since years and stopped the updates for Whynot. Since I do not play (=test) it, I cannot grant the quality of the game. The mod is huge for simple code review ...

Interested in becoming a successor? Are you able to do updates using the buildscripts (If I provide my sources collection tree)? Or do you prefer another way?

The first task is to get the minetest_game mods updated. Considering if the https://github.com/orgs/minetest-game organization is the better source for mods ....

@Lazerbeak12345
About becoming a successor: I've been following this project for a long time and yes I'm interested but there's a problem. While I really want to, I can't become a successor until October 2023. This is due to a two-year project I started in October of this year that takes up most of my time - and I can't reasonably do more than just occasional contributions.

I've read through your buildscripts before. I really like the idea proposed in #34 as it makes it very easy for anyone to pickup. If I symlink the ../../mods_src path hardcoded in ./buildscripts/src-update.sh to ~/.minetest/mods it might work, but I have reasons to doubt that.

As for your last concern, in https://github.com/minetest/minetest it links to https://github.com/minetest/minetest_game/ as the source for minetest_game, so I'd use that as it's "official."

@bell07
While I really want to, I can't become a successor until October 2023

No problem. As you see I have currently less time too. Maybe we can full hand over till 2024 ;-)

What I should do from your point of view at the next to get the hand over easier?

@Lazerbeak12345
Probably do #34 , and as that user suggested keep the versions of every mod exactly the same. I could do some research in how to do this myself, or we could ask them to send the PR.

We need a write-up on what happens to a mod that is currently in WhyNot that fails the rules (Ex: no maintainer means that whynot is the de-facto "new home" of the mod).

Also, I think a rule that requires that mods not be incompatible with one-another could remove the need for that compatibility mod you had to make in it's entirety.

I'll make a separate issue for those last two.

[bell07]

I send invitation to you so you have write access to the repository. So you can adjust documentation and rules for now.

In parallel I started to convert my work area into git repository with submodules. This will be a separate repository, that is able to build whynot game.

If that is done, we should create new github (or gitlab?) organization for the both repositories, and for whynot related mods like whynot_compat or craftguide_reveal.

[Lazerbeak12345]

Yeah, that sounds good to me. For sure I want to to be able to continue to contribute if you would wish to.

[dacmot]

I'm interested in contributing as well, if possible.

[Lazerbeak12345]

Oh hi @dacmot . Small world. I had assumed you weren't active.... are you?

[dacmot]

On and off. I have a young son who likes minetest so I kind of follow his interest level. This past year he's been more interested in lego video games so I mostly didn't play. This time I'm back of my own volition :)

[Lazerbeak12345]

I just made labels (and applied them) for a failing of a specific issue.

During this adventure, I actually wondered if any of these mods don't fail on those issues anymore... but I didn't dig very deep.

If you'd like to correct that go ahead, @bell07 :)

[Lazerbeak12345]

The labels are

• breaks-rule1
• breaks-rule2
• breaks-rule3
• breaks-rule4
• breaks-rule5
• breaks-rule6
• breaks-rule7
• breaks-rule8

[bell07]

@dacmot, Welcome! If you follow the interest level of your child, the Whynot is the right game for you ;-)
The Whynot arise from my Mods collection, I collected for me and my both child's. Therefore there are no adult, drug or weapon mods or something like in game. A not described rule is, the mod should be self-explanatory and playable by child's. For this rule some of Mesecons mods are missed in Whynot, because complicated to use ;-).

I played the game in survival with mayor challenge to reveal recipes and craft all possible. And I was more in Lua-Editor then in the game ;-). The child's played the game mostly together in LAN in creative. In the meantime the child's are in Hyrule or Hogwarts universe, and I currently do not play anything, the Real-Life consumes most of my time ...

I am glad to see to have appreciate successor for that project!

[bell07]

@Lazerbeak12345 , nice idea with the labels!

[Lazerbeak12345]

As I mentioned earlier, I do have a 2 year project ending in 1 October 2023. If @dacmot is capable & willing to do things before that date, we could consider them the "current maintainer" till I'm ready, then either @dacmot and I can co-maintain, or something else.

That's not to say I'm incapable right now - but it is to say that on very short notice I might disappear for very long stretches of time till Oct 2023, when that commitment is over.

[dacmot]

I'm fine with that. I'm just here to help, and I really think WhyNot is worth keeping alive.

[bell07]

I like the idea of Whynot-Team. For 4-eyes for every change the team is to small currently. Therefore feel free to change things and consider new mods for Whynot. I think any of us does as much as he can. For bigger tasks we can use the assignment functionality. If you @Lazerbeak12345 does not have time till end of 2023, no problem.
I will remain contactable and sometimes active as song as necessary since whynot is my "baby".

[bell07]

Tested the glider mod yesterday #19 unsure if it breaks the rules or it is just my subjective point of view for gameplay expectations.
Since I do not really play the game anymore, I decided to not take any decisions about if mod should be applied to the game or not. It's up to You for now.

I still support if decision was taken

[bell07]

@dacmot, I think the last comments should be in the affected issues, since no relation to team-building, my resign

[dacmot]

I will be away on vacation for the next week with no access to a computer other than my phone... just so you don't wonder where I've been :)

[bell07]

I given you both Owner permissions

[dacmot]

Thank you. Now I can edit labels. I should be able to push as well.

[Lazerbeak12345]

Since #53 has been resolved, what issue should be marked as prio-high Issue should be solved as soon as possible next?

[dacmot]

Maybe the achievements?

[Lazerbeak12345]

I've been thinking about using github labels or to organize the issues by what work needs done on them.

Looking through the issues, I think here could be some categories:

• Needs code review
• Needs playtest
• Needs rule-review (IE we need to make sure we go over all of the current whynot rules)
• An issue or PR needs to be made to someone upstream

Also, some metadata

• Role to indicate if it's a modpack

Originally posted in #60

[dacmot]

It looks like whynot has competition from "The best game for Minetest." The description summary says it all: it has everything anyone would ever want 🤣

[Lazerbeak12345]

I've seen that as well. It has two things going for it over ours:

1. They don't have to worry about backwords compatiblity as much (right now)
2. A larger team, so new mods can be added quickly.

I think our rules are valuable, however. I suspect that in due time they will either adopt similar rules to ours, or eventually fail.

[dacmot]

Yeah. It feels a bit more random mish-mash than WNG. Totally first impression, but they don't seem like kind to adopt rules. I do think the rules,our submodule architecture and update script are definitely big advantages for a mod-collection type game.

[dacmot]

@bell07 I'm having trouble creating a webhook package update that works. I keep getting 403 errors with the response "API token does not have access to the package". I think it might be because I created the ContentDB API token and I don't have full access to the package. Would you mind creating a ContentDB API token and updating the secret for the "Github release" webhook on Github?

[bell07]

@dacmot I added you on github to the write permission list.

On ContentDB I see only this setting:

Let me know is something still missed. I am not familiar with authorization settings.

[dacmot]

@bell07 I think it may be a limitation of ContentDB. It could be that only the package owner's API token can be used for webhooks. I followed the instructions here https://content.minetest.net/help/release_webhooks/

[bell07]

I created the token, entered them to the webhook secret and triggered the event delivery.
Now it is working. A new release was created for whynot.

Maybe an issue (Feature request) should be created at https://github.com/minetest/contentdb
The API key should be accepted from any user with organization permissions.

[dacmot]

Great! Thank you. I will create an issue with ContentDB then.