homedecor stairs compatibility

[bell07]

In #49 we get workarounded the stairs support removal.

Now the support is on the way back in mt-mods/homedecor_modpack@2e3a826 thanks to @wsor4035

We should test the change and support it to reach upstream. Then we can remove the workaround frim whynot_compat at
https://github.com/minetest-whynot/whynot-game/blob/main/mods/libs/whynot_compat/init.lua#L132

[Lazerbeak12345]

A cursory review of the code without running it looks like it will work.

It's composed of an array of what looks like hitbox data, along with that loop that more or less matches the loop they gave us earlier.

[Lazerbeak12345]

I've play-tested it, and as-is, I think it'd be fine.

There's only one problem with it, which I think should only be fixed if it's easy, and that's that some items like stairs:slab_fake_grass have incorrect side-textures.

My reasoning for saying this is probably fine is that we are relying on a legacy codepath, and usually I figure that the developer would want it to be functional but just barely. This is just past the "just barely" mark, in my mind.

What are your thoughts @bell07 ?

[bell07]

The change is in homedecor's stair_complaining branch and not merged into master yet.

Unsure if the change will be merged into master. Currently the change is not proposed.

@wsor4035 what is the planned feature for the change?

Since whynot is not a new home for mods, the best case is the change is merged in upstream. Otherwise we need an maintained own fork that we try to avoid.

[Lazerbeak12345]

To clarify (mostly to myself in the future) we have not switched to the proposed "stairs_complaining" branch.