Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would like to contribute more themes in CSS #32

Open
mystery-z opened this issue Nov 14, 2023 · 1 comment
Open

Would like to contribute more themes in CSS #32

mystery-z opened this issue Nov 14, 2023 · 1 comment

Comments

@mystery-z
Copy link

I've been using this for a bit over a month and its great.

I'm kinda disappointed that there's only a dark/light theme though.

I'm happy to write some custom CSS stylesheets and contribute.

Would you be happy to accept some of these?

If so, where can I see the existing CSS code?

@minht11
Copy link
Owner

minht11 commented Nov 14, 2023

How do you imagine these additional themes? Changing just colors or spacing sizes, even more? Completely custom styles are out of the question, styles and ui functionality are tightly coupled so it wouldn't be easy to maintain them.

Right now there is also support for dynamic theming based on artwork color, I likely wouldn't allow changing every single color by the user, because that is bad user experience and more choice isn't isn't always a good thing. Allowing to select few primary colors and shades of darkness, maybe.

Regarding stylesheets, there isn't one central stylesheet, each component defines their own styles, you can see the source code 😁

Overral custom themes are unlikely, variantions of the default theme, lets see, I am interested in your ideas though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants