Optimize checking if track already exists. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for heuristic-ptolemy-02be89 ready! 🔨 Explore the source changes: 73273db 🔍 Inspect the deploy log: https://app.netlify.com/sites/heuristic-ptolemy-02be89/deploys/611d95a51958030007a7437c 😎 Browse the preview: https://deploy-preview-9--heuristic-ptolemy-02be89.netlify.app/ |
|
Wow, this is way faster compared to what I tested. It somehow only took 2 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously each file handle was compared to one another using only
isSameEntry, that's very expensive. Now we check if file names are also matching before usingisSameEntry, because if file is renamed it will automatically won't match, so it's safe to do that. Other optimization is removing already found tracks from existing tracks search pool.Original diff, on my machine, with 462 tracks, took 11000ms, with this PR it takes about 300ms. 36x times improvement. Still this could be optimized even more.
Partially fixes #8