Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add nostr PFPs of zap senders #100

Open
alltheseas opened this issue Sep 4, 2024 · 3 comments
Open

[Feature] Add nostr PFPs of zap senders #100

alltheseas opened this issue Sep 4, 2024 · 3 comments
Labels
enhancement New feature or request testing UI/UX

Comments

@alltheseas
Copy link

In

  1. wallet view, and
  2. transaction view

To the left of each "received zap" or zap comment consider adding a nostr PFP of the sender, so that it is easier to see who zapped me

@alltheseas
Copy link
Author

alltheseas commented Sep 8, 2024

mockup with random PFPs I found

PFPmockup

@minibits-cash
Copy link
Owner

Requirement ack.

Note to self: will require zap senderProfile to be sent from lnurl server

@minibits-cash minibits-cash changed the title Add nostr PFPs of zap senders [Feature] Add nostr PFPs of zap senders Sep 8, 2024
@minibits-cash minibits-cash added enhancement New feature or request UI/UX testing labels Sep 8, 2024
@minibits-cash
Copy link
Owner

Released for testing in 0.1.8-beta.65.

Sender profile pictures are shown for received zaps or for ecash received over encrypted Nostr message from another user ("Send to contact" in Minibits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request testing UI/UX
Projects
None yet
Development

No branches or pull requests

2 participants