From 68cc62955841b15cdb0182b60345c6298f510989 Mon Sep 17 00:00:00 2001
From: Benjamin Perez <benjamin@bexsoft.net>
Date: Wed, 20 Nov 2024 17:06:42 -0600
Subject: [PATCH] Added missing type prop to inner buttons

Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
---
 .storybook/preview.tsx                            | 2 +-
 src/components/Breadcrumbs/BreadcrumbButton.tsx   | 1 +
 src/components/DateTimeInput/DateTimeSelector.tsx | 2 ++
 src/components/DateTimeInput/TimeSelector.tsx     | 1 +
 src/components/ExpandMenu/ExpandMenuOption.tsx    | 1 +
 src/components/LinkButton/index.tsx               | 1 +
 src/components/ModalBox/index.tsx                 | 7 ++++++-
 src/components/NotificationAlert/index.tsx        | 2 +-
 src/components/Tabs/TabButton.tsx                 | 1 +
 src/components/Tag/index.tsx                      | 6 +++++-
 src/components/Wizard/index.tsx                   | 1 +
 11 files changed, 21 insertions(+), 4 deletions(-)

diff --git a/.storybook/preview.tsx b/.storybook/preview.tsx
index 43d193d74..260652a56 100644
--- a/.storybook/preview.tsx
+++ b/.storybook/preview.tsx
@@ -49,7 +49,7 @@ const preview: Preview = {
     },
   },
 
-  tags: ["autodocs"]
+  tags: ["autodocs"],
 };
 
 export default preview;
diff --git a/src/components/Breadcrumbs/BreadcrumbButton.tsx b/src/components/Breadcrumbs/BreadcrumbButton.tsx
index 6dd2c4689..1ef723936 100644
--- a/src/components/Breadcrumbs/BreadcrumbButton.tsx
+++ b/src/components/Breadcrumbs/BreadcrumbButton.tsx
@@ -114,6 +114,7 @@ const BreadcrumbButton: FC<
   return (
     <Fragment>
       <button
+        type={"button"}
         css={[breadcrumbButtonTheme]}
         onClick={onClick}
         disabled={disabled || false}
diff --git a/src/components/DateTimeInput/DateTimeSelector.tsx b/src/components/DateTimeInput/DateTimeSelector.tsx
index 2b2ff3cda..1ad00fdd6 100644
--- a/src/components/DateTimeInput/DateTimeSelector.tsx
+++ b/src/components/DateTimeInput/DateTimeSelector.tsx
@@ -152,6 +152,7 @@ const DateTimeSelector: FC<DateTimeSelectorProps> = ({
             css={[optionChangeButton]}
             className={currentView === "calendar" ? "selected" : ""}
             onClick={() => setCurrentView("calendar")}
+            type={"button"}
           >
             <CalendarIcon />
             <span>{value?.toFormat("dd LLL yyyy") || ""}</span>
@@ -160,6 +161,7 @@ const DateTimeSelector: FC<DateTimeSelectorProps> = ({
             css={[optionChangeButton]}
             className={currentView === "time" ? "selected" : ""}
             onClick={() => setCurrentView("time")}
+            type={"button"}
           >
             <Clock4Icon />
             <span>
diff --git a/src/components/DateTimeInput/TimeSelector.tsx b/src/components/DateTimeInput/TimeSelector.tsx
index f5b3d2d68..d52d8b04d 100644
--- a/src/components/DateTimeInput/TimeSelector.tsx
+++ b/src/components/DateTimeInput/TimeSelector.tsx
@@ -125,6 +125,7 @@ const TimeSelector: FC<TimeSelectorProps> = ({
     type: "hour" | "minute" | "second" | "meridiem";
   }) => (
     <button
+      type={"button"}
       css={selectorButton}
       onClick={() => {
         changeTimeAction(itemValue, type);
diff --git a/src/components/ExpandMenu/ExpandMenuOption.tsx b/src/components/ExpandMenu/ExpandMenuOption.tsx
index 6451903e2..13854eb53 100644
--- a/src/components/ExpandMenu/ExpandMenuOption.tsx
+++ b/src/components/ExpandMenu/ExpandMenuOption.tsx
@@ -51,6 +51,7 @@ const ExpandMenuOption: FC<
   return (
     <button
       id={id}
+      type={"button"}
       className={`option-element ${variant}`}
       css={[expandMenuOptionStyles(theme), extraPadding, overrideThemes]}
       {...restProps}
diff --git a/src/components/LinkButton/index.tsx b/src/components/LinkButton/index.tsx
index 59d6746e7..496feba51 100644
--- a/src/components/LinkButton/index.tsx
+++ b/src/components/LinkButton/index.tsx
@@ -43,6 +43,7 @@ const LinkButton: FC<LinkButtonProps> = ({
 
   return (
     <button
+      type={"button"}
       className="LinkButton"
       css={[buttonVariant, overrideThemes]}
       {...props}
diff --git a/src/components/ModalBox/index.tsx b/src/components/ModalBox/index.tsx
index d3e480082..d7ee68bb7 100644
--- a/src/components/ModalBox/index.tsx
+++ b/src/components/ModalBox/index.tsx
@@ -61,7 +61,12 @@ const ModalBox: FC<ModalBoxProps> = ({
             {titleIcon}
             {title}
           </div>
-          <button className={"closeModalButton"} id={"close"} onClick={onClose}>
+          <button
+            type={"button"}
+            className={"closeModalButton"}
+            id={"close"}
+            onClick={onClose}
+          >
             <XIcon />
           </button>
         </div>
diff --git a/src/components/NotificationAlert/index.tsx b/src/components/NotificationAlert/index.tsx
index be47886b9..d0e266c71 100644
--- a/src/components/NotificationAlert/index.tsx
+++ b/src/components/NotificationAlert/index.tsx
@@ -256,7 +256,7 @@ const Index: FC<NotificationAlertPrp & HTMLAttributes<HTMLDivElement>> = ({
         </div>
       </div>
       {onClose && (
-        <button className={"dismissAlert"} onClick={onClose}>
+        <button type={"button"} className={"dismissAlert"} onClick={onClose}>
           <XIcon />
         </button>
       )}
diff --git a/src/components/Tabs/TabButton.tsx b/src/components/Tabs/TabButton.tsx
index a51a2bf7b..e91e4247d 100644
--- a/src/components/Tabs/TabButton.tsx
+++ b/src/components/Tabs/TabButton.tsx
@@ -41,6 +41,7 @@ const TabButton: FC<TabButtonProps> = ({
       onClick={() => onClick()}
       disabled={disabled}
       className={`${selected ? "selected" : ""}`}
+      type={"button"}
     >
       {icon}
       {label}
diff --git a/src/components/Tag/index.tsx b/src/components/Tag/index.tsx
index 3fe44a8c6..c98f79680 100644
--- a/src/components/Tag/index.tsx
+++ b/src/components/Tag/index.tsx
@@ -58,7 +58,11 @@ const Tag: FC<TagProps & React.HTMLAttributes<HTMLSpanElement>> = ({
         {children}
       </span>
       {onDelete && (
-        <button className={"deleteTagButton"} onClick={() => onDelete(id)}>
+        <button
+          type={"button"}
+          className={"deleteTagButton"}
+          onClick={() => onDelete(id)}
+        >
           <XIcon />
         </button>
       )}
diff --git a/src/components/Wizard/index.tsx b/src/components/Wizard/index.tsx
index 5d9a5b99c..fee83631e 100644
--- a/src/components/Wizard/index.tsx
+++ b/src/components/Wizard/index.tsx
@@ -93,6 +93,7 @@ const GenericWizard = ({
           {wizardSteps.map((step, index) => {
             return (
               <button
+                type={"button"}
                 key={`wizard-step-${index}`}
                 id={"wizard-step-" + step.label.toLowerCase().replace(" ", "-")}
                 onClick={() => pageChange(index)}