Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithSSL(false) is ignored with MinioClientFactory #878

Closed
fabientrissie opened this issue Oct 6, 2023 · 4 comments
Closed

WithSSL(false) is ignored with MinioClientFactory #878

fabientrissie opened this issue Oct 6, 2023 · 4 comments

Comments

@fabientrissie
Copy link

fabientrissie commented Oct 6, 2023

Hi, I think there is an issue when we want to inject a Minio client without using SSL.

Here's my code in my program.cs

builder.Services.AddMinio(client =>
{
client.WithEndpoint(endpoint)
.WithCredentials(accessKey, secretKey)
.WithSSL(false)
.Build();
});

But the client always have secure to True in my service classes.

I check the source code and I can this in "MinioClientFactory.cs" line 40 this code, and I think my configuration is ignored because of that :

var client = new MinioClient()
.WithSSL();

configureClient(client);

Thanks for your help

@S3V3N-11
Copy link

S3V3N-11 commented Oct 7, 2023

Hey, I have the same problem.

Program.cs
image

Injected MinioClient
image

@ebozduman
Copy link
Collaborator

Duplicate of #884
This issue is addressed in PR #844
Closing...

@forever84721
Copy link

The problem with WithSSL(false) seems still same.
Is it because the new version has not been released to nuget yet?
I see that nuget is still version 6.0.0 on 2023/9/30

@ebozduman
Copy link
Collaborator

Yes, @forever84721
We haven't generated a new nuget package yet.
Please try it out the master branch from the top of the minio-dotnet repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants