You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR #1546 the logic was added to close httpClient when closing minio client.
However, if a custom httpClient is passed to the builder then closeHttpClient is set to false
Yes. For custom http client, we do not set to close because it is user's responsibility when to close it. You could add a new builder method like public Builder httpClient(OkHttpClient httpClient, boolean close).
In PR #1546 the logic was added to close
httpClient
when closing minio client.However, if a custom
httpClient
is passed to the builder thencloseHttpClient
is set tofalse
Here is the code from
MinioAsyncClient.java
So we set
closeHttpClient
totrue
only whenhttpClient
is not passed to the builder and we create a default oneMy proposal is to allow to pass
closeHttpClient
to the builder and even make ittrue
by defaultI can create PR for this if the idea is approved
The text was updated successfully, but these errors were encountered: