From a72a93b06a4c5cd7b0e26adad0d28c207833c144 Mon Sep 17 00:00:00 2001
From: "Nicholas H.Tollervey" <ntoll@ntoll.org>
Date: Tue, 1 Dec 2020 16:42:06 +0000
Subject: [PATCH] Ensure buttons marked cpanel-button--destructive have
 confirmation alerts.

---
 controlpanel/frontend/jinja2/datasource-access-update.html | 2 +-
 controlpanel/frontend/jinja2/includes/parameter-list.html  | 2 +-
 controlpanel/frontend/jinja2/policy-update.html            | 2 +-
 controlpanel/frontend/jinja2/webapp-detail.html            | 6 +++---
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/controlpanel/frontend/jinja2/datasource-access-update.html b/controlpanel/frontend/jinja2/datasource-access-update.html
index 6f5836950..384796a5f 100644
--- a/controlpanel/frontend/jinja2/datasource-access-update.html
+++ b/controlpanel/frontend/jinja2/datasource-access-update.html
@@ -54,7 +54,7 @@ <h2 class="govuk-error-summary__title" id="error-summary-title">
 <section class="cpanel-section">
   <form method="post" action="{{ revoke_url }}">
     {{ csrf_input }}
-    <button class="govuk-button cpanel-button--destructive">Revoke access</button>
+    <button class="govuk-button cpanel-button--destructive js-confirm">Revoke access</button>
   </form>
 </section>
 {% endif %}
diff --git a/controlpanel/frontend/jinja2/includes/parameter-list.html b/controlpanel/frontend/jinja2/includes/parameter-list.html
index e8590900e..7a04a0c82 100644
--- a/controlpanel/frontend/jinja2/includes/parameter-list.html
+++ b/controlpanel/frontend/jinja2/includes/parameter-list.html
@@ -20,7 +20,7 @@
       <td class="govuk-table__cell">
         <form method="POST" action="{{ url("delete-parameter", kwargs={ "pk": parameter.id }) }}">
             {{ csrf_input }}
-            <button class="govuk-button cpanel-button--destructive">Delete parameter</button>
+            <button class="govuk-button cpanel-button--destructive js-confirm">Delete parameter</button>
         </form>
       </td>
     </tr>
diff --git a/controlpanel/frontend/jinja2/policy-update.html b/controlpanel/frontend/jinja2/policy-update.html
index 446b0faba..561a3f884 100644
--- a/controlpanel/frontend/jinja2/policy-update.html
+++ b/controlpanel/frontend/jinja2/policy-update.html
@@ -63,6 +63,6 @@ <h1 class="govuk-heading-xl">{{ page_title }}</h1>
 
   <form method="POST" action="{{ url("delete-policy", kwargs={ "pk": policy.id }) }}">
       {{ csrf_input }}
-      <button class="govuk-button cpanel-button--destructive">Delete group</button>
+      <button class="govuk-button cpanel-button--destructive js-confirm">Delete group</button>
   </form>
 {% endblock %}
diff --git a/controlpanel/frontend/jinja2/webapp-detail.html b/controlpanel/frontend/jinja2/webapp-detail.html
index 982f3c331..979c7b34c 100644
--- a/controlpanel/frontend/jinja2/webapp-detail.html
+++ b/controlpanel/frontend/jinja2/webapp-detail.html
@@ -170,7 +170,7 @@ <h2 class="govuk-heading-m">
           {% if user.id %}
             <form action="{{ url('revoke-app-admin', kwargs={ "pk": app.id, "user_id": user.id }) }}" method="post">
               {{ csrf_input }}
-              <button class="confirm govuk-button govuk-button--secondary right">
+              <button class="js-confirm govuk-button govuk-button--secondary right">
               Revoke admin
               </button>
             </form>
@@ -247,14 +247,14 @@ <h2 class="govuk-heading-m">App data sources</h2>
           <form action="{{ url('update-app-access', kwargs={ "pk": bucket.id }) }}" method="post" class="form-control-prefix">
             {{ csrf_input }}
             <input type="hidden" name="access_level" value="{{ yes_no(bucket.access_level, 'readwrite', 'readonly', 'readwrite') }}">
-            <button class="confirm govuk-button govuk-button--secondary">
+            <button class="js-confirm govuk-button govuk-button--secondary">
               Set {{ yes_no(bucket.access_level, 'readwrite', 'read only', 'read/write') }}
             </button>
           </form>
           {% if request.user.has_perm('api.remove_app_bucket', app) %}
           <form action="{{ url('revoke-app-access', kwargs={ "pk": bucket.id }) }}" method="post" class="form-control-prefix">
             {{ csrf_input }}
-            <button class="confirm govuk-button govuk-button--secondary">
+            <button class="js-confirm govuk-button govuk-button--secondary">
               Disconnect
             </button>
           </form>