From ee68287e501e3999d3e75dd963aaf3f8e6f3cc17 Mon Sep 17 00:00:00 2001
From: julialawrence <julia.lawrence@digital.justice.gov.uk>
Date: Mon, 23 Oct 2023 14:26:13 +0100
Subject: [PATCH] I think it's dying on popup.

---
 app/app.py                             |  2 +-
 app/templates/data_source_details.html | 16 +++++++++++++---
 2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/app/app.py b/app/app.py
index 5832317..b41705f 100644
--- a/app/app.py
+++ b/app/app.py
@@ -438,7 +438,7 @@ def start_vscode(id):
     # Redirect to a waiting page or directly embed the VS Code interface if it's ready
     # The implementation of this part can vary based on how you handle the VS Code UI embedding
     # return render_template("vscode.html")
-    vscode_url = url_for('vscode_proxy', _external=True)
+    vscode_url = url_for('vscode_proxy')
     return redirect(vscode_url)
 
 
diff --git a/app/templates/data_source_details.html b/app/templates/data_source_details.html
index 5c915da..d04c73c 100644
--- a/app/templates/data_source_details.html
+++ b/app/templates/data_source_details.html
@@ -4,6 +4,7 @@
     <meta charset="UTF-8">
     <title>Data Source Details</title>
     <!-- You can add CSS or additional meta tags here -->
+    <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.5.1/jquery.min.js"></script>  <!-- Include jQuery -->
 </head>
 <body>
 
@@ -41,11 +42,20 @@ <h3>Assigned Users:</h3>
 <!-- Check if the user has the necessary permissions to launch VS Code -->
 {% if is_admin or user_has_access %}
     <!-- Button to launch VS Code -->
-    <form action="{{ url_for('start_vscode', id=data_source.id) }}" method="post">
-        <input type="submit" value="Launch VS Code">
-    </form>
+    <button onclick="launchVSCode()">Launch VS Code</button>
 {% endif %}
 
+<script type="text/javascript">
+    function launchVSCode() {
+        // Send an AJAX POST request to start_vscode
+        $.post("{{ url_for('start_vscode', id=data_source.id) }}", function() {
+            // On success, open the vscode_proxy URL in a new tab
+            var url = "{{ url_for('vscode_proxy') }}";
+            window.open(url, '_blank');
+        });
+    }
+</script>
+
 <!-- Link to go back to the list of data sources -->
 <a href="{{ url_for('list_data_sources') }}">Back to Data Sources List</a>
 
