From c983a7a6a035ffbb4f176d499e52f7e83ee5e6d3 Mon Sep 17 00:00:00 2001 From: "Joseph.Dundon" Date: Mon, 28 Oct 2024 10:14:18 +0000 Subject: [PATCH] PI-2575 - PR Review Feedback --- .../common-platform-and-delius/deploy/values-dev.yml | 2 -- .../deploy/values-preprod.yml | 2 -- .../common-platform-hearing-blank-address.json | 10 +--------- .../messages/common-platform-hearing-dob-error.json | 10 +--------- .../messages/common-platform-hearing-no-cases.json | 10 +--------- .../messages/common-platform-hearing-no-remand.json | 10 +--------- .../resources/messages/common-platform-hearing.json | 10 +--------- 7 files changed, 5 insertions(+), 49 deletions(-) diff --git a/projects/common-platform-and-delius/deploy/values-dev.yml b/projects/common-platform-and-delius/deploy/values-dev.yml index 2da8364e6f..a8c31413d2 100644 --- a/projects/common-platform-and-delius/deploy/values-dev.yml +++ b/projects/common-platform-and-delius/deploy/values-dev.yml @@ -1,5 +1,3 @@ -enabled: false - generic-service: ingress: host: common-platform-and-delius-dev.hmpps.service.justice.gov.uk diff --git a/projects/common-platform-and-delius/deploy/values-preprod.yml b/projects/common-platform-and-delius/deploy/values-preprod.yml index 3aa1c2df9d..a46cf293f4 100644 --- a/projects/common-platform-and-delius/deploy/values-preprod.yml +++ b/projects/common-platform-and-delius/deploy/values-preprod.yml @@ -1,5 +1,3 @@ -enabled: false - generic-service: ingress: host: common-platform-and-delius-preprod.hmpps.service.justice.gov.uk diff --git a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-blank-address.json b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-blank-address.json index 9019f25707..75e68cf81b 100644 --- a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-blank-address.json +++ b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-blank-address.json @@ -9,21 +9,13 @@ "SigningCertURL": "https://sns.eu-west-2.amazonaws.com/EXAMPLE.pem", "UnsubscribeURL": "https://sns.eu-west-2.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=EXAMPLE", "MessageAttributes": { - "tracestate": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" - }, - "eventType": { + "messageType": { "Type": "String", "Value": "COMMON_PLATFORM_HEARING" }, "hearingEventType": { "Type": "String", "Value": "ConfirmedOrUpdated" - }, - "traceparent": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" } } } \ No newline at end of file diff --git a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-dob-error.json b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-dob-error.json index 9fa9635423..f1d063a494 100644 --- a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-dob-error.json +++ b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-dob-error.json @@ -9,21 +9,13 @@ "SigningCertURL": "https://sns.eu-west-2.amazonaws.com/EXAMPLE.pem", "UnsubscribeURL": "https://sns.eu-west-2.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=EXAMPLE", "MessageAttributes": { - "tracestate": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" - }, - "eventType": { + "messageType": { "Type": "String", "Value": "COMMON_PLATFORM_HEARING" }, "hearingEventType": { "Type": "String", "Value": "ConfirmedOrUpdated" - }, - "traceparent": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" } } } \ No newline at end of file diff --git a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-no-cases.json b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-no-cases.json index 4ad08dbe7d..fc5ac34f87 100644 --- a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-no-cases.json +++ b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-no-cases.json @@ -9,21 +9,13 @@ "SigningCertURL": "https://sns.eu-west-2.amazonaws.com/EXAMPLE.pem", "UnsubscribeURL": "https://sns.eu-west-2.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=EXAMPLE", "MessageAttributes": { - "tracestate": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" - }, - "eventType": { + "messageType": { "Type": "String", "Value": "COMMON_PLATFORM_HEARING" }, "hearingEventType": { "Type": "String", "Value": "ConfirmedOrUpdated" - }, - "traceparent": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" } } } \ No newline at end of file diff --git a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-no-remand.json b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-no-remand.json index bf41743b9e..f88a497a1f 100644 --- a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-no-remand.json +++ b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing-no-remand.json @@ -8,21 +8,13 @@ "SigningCertURL": "https://sns.eu-west-2.amazonaws.com/EXAMPLE.pem", "UnsubscribeURL": "https://sns.eu-west-2.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=EXAMPLE", "MessageAttributes": { - "tracestate": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" - }, - "eventType": { + "messageType": { "Type": "String", "Value": "COMMON_PLATFORM_HEARING" }, "hearingEventType": { "Type": "String", "Value": "ConfirmedOrUpdated" - }, - "traceparent": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" } } } \ No newline at end of file diff --git a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing.json b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing.json index 8c082bb0bd..8e61a1e5cd 100644 --- a/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing.json +++ b/projects/common-platform-and-delius/src/dev/resources/messages/common-platform-hearing.json @@ -9,21 +9,13 @@ "SigningCertURL": "https://sns.eu-west-2.amazonaws.com/EXAMPLE.pem", "UnsubscribeURL": "https://sns.eu-west-2.amazonaws.com/?Action=Unsubscribe&SubscriptionArn=EXAMPLE", "MessageAttributes": { - "tracestate": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" - }, - "eventType": { + "messageType": { "Type": "String", "Value": "COMMON_PLATFORM_HEARING" }, "hearingEventType": { "Type": "String", "Value": "ConfirmedOrUpdated" - }, - "traceparent": { - "Type": "String", - "Value": "00-01a234b56c7de8f9g01h234i56789j0k-1l234m567n8o9p01-01" } } } \ No newline at end of file