Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PI-1473 add enhancement ability for domain events #2295

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Conversation

anthony-britton-moj
Copy link
Contributor

@anthony-britton-moj anthony-britton-moj commented Sep 20, 2023

Part one about ready - ability to add the detail url (or any other information desired) to a domain event
Part two to add the api reading ability - detail url added for probation-case.engagement.created

@anthony-britton-moj anthony-britton-moj requested a review from a team as a code owner September 20, 2023 15:19
@github-actions github-actions bot added the enhancement New feature or request label Sep 20, 2023
@anthony-britton-moj anthony-britton-moj marked this pull request as draft September 20, 2023 15:20
@anthony-britton-moj anthony-britton-moj marked this pull request as ready for review September 21, 2023 09:20
Copy link
Contributor

@marcus-bcl marcus-bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought, happy to leave it as is - but should we prefix the path with something like "/details/..."? E.g.

domain-events-and-delius.hmpps.service.justice.gov.uk/details/probation-case.engagement.created/A123456

in case we ever need to add any other API endpoints (unrelated to event details) to this service?

@anthony-britton-moj
Copy link
Contributor Author

anthony-britton-moj commented Sep 21, 2023

Just a thought, happy to leave it as is - but should we prefix the path with something like "/details/..."? E.g.

domain-events-and-delius.hmpps.service.justice.gov.uk/details/probation-case.engagement.created/A123456

in case we ever need to add any other API endpoints (unrelated to event details) to this service?

My initial thoughts were to add details in the url, however, I then thought we would not want to add other API endpoints that were not related to event details -- it's in the name - domain event service? Everything we put here should be related to domain events, and probably only the detail for them. Other endpoints would probably go elsewhere, otherwise we risk another community-api scenario?
If we did want to change it later - given we produce the detail url, we can also update to include details - but at the moment it feels a little redundant.

@anthony-britton-moj anthony-britton-moj merged commit 499629d into main Sep 21, 2023
34 checks passed
@anthony-britton-moj anthony-britton-moj deleted the ab_PI-1473 branch September 21, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants