Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PI-1505 DPS probation document endpoints #2421

Merged
merged 3 commits into from
Oct 23, 2023
Merged

PI-1505 DPS probation document endpoints #2421

merged 3 commits into from
Oct 23, 2023

Conversation

marcus-bcl
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the enhancement New feature or request label Oct 19, 2023
@marcus-bcl marcus-bcl force-pushed the PI-1505-dps-documents branch from b9ee602 to 8d1146d Compare October 23, 2023 08:17
@marcus-bcl marcus-bcl marked this pull request as ready for review October 23, 2023 08:45
@marcus-bcl marcus-bcl requested a review from a team as a code owner October 23, 2023 08:45
@marcus-bcl marcus-bcl changed the title PI-1505 Initial grouped documents endpoint PI-1505 DPS probation document endpoints Oct 23, 2023
anthony-britton-moj
anthony-britton-moj previously approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@anthony-britton-moj anthony-britton-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - however I would question why the entities are data classes ? Doesn't seem like they need to be and given the potential complications of data classes with JPA it might be better to avoid them

@marcus-bcl
Copy link
Contributor Author

Approved - however I would question why the entities are data classes ? Doesn't seem like they need to be and given the potential complications of data classes with JPA it might be better to avoid them

Good point - updated

@marcus-bcl marcus-bcl merged commit 2fd8fbf into main Oct 23, 2023
34 of 35 checks passed
@marcus-bcl marcus-bcl deleted the PI-1505-dps-documents branch October 23, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony-britton-moj anthony-britton-moj anthony-britton-moj approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcus-bcl @anthony-britton-moj