From 0425bc2f4dcca3db0220ea9175cafe9cd1fead27 Mon Sep 17 00:00:00 2001 From: Greg Tyler Date: Fri, 4 Dec 2020 19:22:33 +0000 Subject: [PATCH] Going directly to an incident page does not take you through the login journey (#64) * Fix login URL Needs a leading slash or it's treated as relative * Replace sign out link with context You can't sign out and you can only disconnect through GitHub, so no point having a link that implies otherwise --- opgincidentresponse/settings/base.py | 2 +- opgincidentresponse/templates/govuk_base.html | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/opgincidentresponse/settings/base.py b/opgincidentresponse/settings/base.py index 6a91191..5f353d3 100644 --- a/opgincidentresponse/settings/base.py +++ b/opgincidentresponse/settings/base.py @@ -230,7 +230,7 @@ def get_env_var(setting, warn_only=False): PAGERDUTY_SERVICE = get_env_var("PAGERDUTY_SERVICE") PAGERDUTY_EMAIL = get_env_var("PAGERDUTY_EMAIL") -LOGIN_URL = "login/github-org" +LOGIN_URL = "/login/github-org" # Whether to use https://pypi.org/project/bleach/ to strip potentially dangerous # HTML input in string fields diff --git a/opgincidentresponse/templates/govuk_base.html b/opgincidentresponse/templates/govuk_base.html index 62bb1ce..fe6aa74 100644 --- a/opgincidentresponse/templates/govuk_base.html +++ b/opgincidentresponse/templates/govuk_base.html @@ -93,7 +93,7 @@ > - OPG Incident Response + OPG Incident Response
@@ -101,7 +101,7 @@