-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vmtag is inconsistent in Minos, mvm and Linux #43
Comments
Very good suggestion. For vmtag, may be we need a better way to replace it. We can brainstorm. I already have related plans to make the kernel related code can be compiled into a kernel module. In addition, mvm and kernel module can be separated into separate git. |
I think we can move below content from ramdisk.h to hypervisor.h. the definition of ramdisk may used in other tools or code, the purpose of hypervisor.h is used to share with different module (such as mvm and kernel), then other module only need copy the hypervisor.h to its code base.
|
- changes vmtag - changes __packed This may fix that the guest VM can't be created. Related to #40, #43 Signed-off-by: Lei Feng <[email protected]>
#40 changed Minos'
struct vmtag
, but did not change mvm's and Linux's. This leads to a problem that when creating a guest VM instead of a native VM, Minos gets avmtag
in a different format.I think we need some mechanism to mark the version of
vmtag
, such asvmtag_size
. And we need to ensure that new members are added to the end ofvmtag
.By the way, I recommend maintaining the kernel mode code in this project, just like
mvm
.The text was updated successfully, but these errors were encountered: