New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zip_with function, optimize list unique & compare function and support a SmartContract as order's sender #7

Merged

h2physics merged 4 commits into main from richard/fix-zip-with-and-unique

Jan 13, 2024

Member

h2physics commented Nov 27, 2023 •

edited

Loading

zip_with function works incorrectly if array 1 has more items than array 2: https://github.com/minswap/stableswap-txpipe/pull/7/files#diff-8b7e5b095908a3792ee9c28541f5e72b6bf25a53fc47f49ed14210d07870b729R85
Write custom comparing 2 lists' length function: https://github.com/minswap/stableswap-txpipe/pull/7/files#diff-8b7e5b095908a3792ee9c28541f5e72b6bf25a53fc47f49ed14210d07870b729R85
Write custom function for checking unique list: https://github.com/minswap/stableswap-txpipe/pull/7/files#diff-8b7e5b095908a3792ee9c28541f5e72b6bf25a53fc47f49ed14210d07870b729R85
Allow order's sender is a smart contract: https://github.com/minswap/stableswap-txpipe/pull/7/files#diff-a1f24860a34f495da74370d8b98acc5dcb0f5632edd1d03f59c494ad6ce0f09eR38-R64
Use Withdrawal Script (Order Batching script) on Batching Transaction to minimize Order Execution Cost: https://github.com/minswap/stableswap-txpipe/pull/7/files#diff-a1f24860a34f495da74370d8b98acc5dcb0f5632edd1d03f59c494ad6ce0f09eR65-R85
Remove Batcher Address in ApplyPool Redeemer: We have plan to decentralize Batcher, Batcher can be PubKey or Multi-sign Address in the future. Therefore we remove batcher signature condition and detect its address via License Input
https://github.com/minswap/stableswap-txpipe/pull/7/files#diff-8b142f1373aaeaea50e2c983783ddc949910f1f7d43f3a7ddc270401a0418cf8R151-R165


          fix zip_with function, optimize list unique & compare function

729a697

h2physics requested review from longngn and MicroProofs

November 27, 2023 04:38

h2physics added 3 commits

November 30, 2023 10:26


          add Withdrawal Script

ec0d46c


          remove batcher address from ApplyPool redeemer


          use list.any for minimizing cost

dcc75cf

h2physics merged commit 2bee65b into main

1 check passed

h2physics deleted the richard/fix-zip-with-and-unique branch

January 13, 2024 03:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet