More small fixes

Author: azarovh

chainstate/test-framework/src/block_builder.rs

@@ -123,7 +123,7 @@ impl<'f> BlockBuilder<'f> {
     pub fn add_test_transaction(
         mut self,
         rng: &mut (impl Rng + CryptoRng),
-        supper_htlc: bool,
+        support_htlc: bool,
     ) -> Self {
         let utxo_set = self
             .framework
@@ -152,7 +152,7 @@ impl<'f> BlockBuilder<'f> {
                 &self.pos_accounting_store,
                 None,
                 account_nonce_getter,
-                supper_htlc,
+                support_htlc,
             )
             .make(
                 rng,

chainstate/test-framework/src/random_tx_maker.rs

@@ -838,7 +838,8 @@ impl<'a> RandomTxMaker<'a> {
                                     TxOutput::Transfer(OutputValue::Coin(new_value), destination)
                                 }
                             }
-                            _ => TxOutput::Transfer(OutputValue::Coin(new_value), destination),
+                            2..=4 => TxOutput::Transfer(OutputValue::Coin(new_value), destination),
+                            _ => unreachable!(),
                         }
                     }
                 })

common/src/chain/transaction/output/htlc.rs

@@ -21,15 +21,6 @@ use serialization::{Decode, Encode};
 
 use super::{timelock::OutputTimeLock, Destination};
 
-fixed_hash::construct_fixed_hash! {
-    #[derive(Encode, Decode, serde::Serialize, serde::Deserialize)]
-    pub struct SecretHash(20);
-}
-
-impl rpc_description::HasValueHint for SecretHash {
-    const HINT_SER: rpc_description::ValueHint = rpc_description::ValueHint::HEX_STRING;
-}
-
 #[derive(Debug, Clone, PartialEq, Eq, Encode, Decode, serde::Serialize, serde::Deserialize)]
 pub struct HashedTimelockContract {
     // can be spent either by a specific address that knows the secret