Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohttp_eio.Server.run is hardcoded to listen on loopback #1001

Closed
yawaramin opened this issue Oct 15, 2023 · 2 comments
Closed

Cohttp_eio.Server.run is hardcoded to listen on loopback #1001

yawaramin opened this issue Oct 15, 2023 · 2 comments
Labels
Bug Feature

Comments

@yawaramin
Copy link

Which prevents from using it in a Docker container. Need to allow passing in an address e.g.

val run :
  ?socket_backlog:int ->
  ?domains:int ->
  ?addr:_ Eio.Net.Ipaddr.t ->
  port:int ->
  _ env ->
  handler ->
  _
@mseri
Copy link
Collaborator

mseri commented Oct 15, 2023

I think the upcoming one solves the issue, or I am wrong? https://github.com/mirage/ocaml-cohttp/pull/984/files#diff-22b96a38d53e72e635d26efa1dd510bf757e3d25ce919c8e4367187238c36be2R50

@yawaramin
Copy link
Author

Right! Fixed by #984

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yawaramin @mseri