Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking, tls and windows #264

Closed
dinosaure opened this issue May 28, 2018 · 2 comments
Closed

Linking, tls and windows #264

dinosaure opened this issue May 28, 2018 · 2 comments
Assignees

Comments

@dinosaure
Copy link
Member

It seems we have a linking bug when we want to have the SSL support on cohttp. I really don't know what happens but, on ocaml-git, if I want to use tls, I did not have any problem on Linux but (cf. mirleft/ocaml-nocrypto#135) I have a problem on Windows.

So, a solution could be "(ssl | tls)" as a dependency of git-unix but neither Travis nor Appveyor is happy ... Then, with a little discussion with @samoht, the problem seems to be in conduit. So it's why I created this issue.

@samoht
Copy link
Member

samoht commented May 28, 2018

The cause is mirleft/ocaml-nocrypto#135

conduit.unix should stop linking to nocrypto.unix unconditionally as this will never work (at leats, until someone ports nocrypto.unix to windows)

@samoht
Copy link
Member

samoht commented Jun 21, 2018

We need to define tls as an optional dependency only on non-windows, but I am not sure it is possible with opam 1.2 syntax.

samoht added a commit to samoht/ocaml-conduit that referenced this issue Jul 16, 2018
samoht added a commit to samoht/ocaml-conduit that referenced this issue Jul 16, 2018
samoht added a commit to samoht/ocaml-conduit that referenced this issue Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants