Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0 #1363

Closed
7 of 10 tasks
samselikoff opened this issue Aug 7, 2018 · 6 comments
Closed
7 of 10 tasks

v1.0 #1363

samselikoff opened this issue Aug 7, 2018 · 6 comments

Comments

@samselikoff
Copy link
Collaborator

samselikoff commented Aug 7, 2018

  • change normalizeIds default on AMS/RestSerializer to true (0d93eac closes)
  • Faker.js work in Make Faker.js a user-configured dependency #1037
  • Pretender work in Allow host apps to specify their own version of Pretender #1469
  • Revisit lodash stuff. Possibly remove?
  • remove deprecated behavior of plural model name to create/createList
  • the camelCase vs. dasherized stuff is rough and confusing. Is there some sort of check/assertion/typing we can introduce so this is less of a pain going forward?
  • Look for "This behavior will be removed in 1.0." comments
  • skipped tests
  • consider simplifying factory/fixture logic in config()? more explicit? Maybe v2
  • deprecate object handler (fat arrow functions returning objects are commonplace now) Maybe v2
@nightire
Copy link

and upgrade pretender up to v2.1+, to support native fetch. currently with ember-fetch, you can not opt in native fetch, because pretender doesn't know how to intercept a native fetch call.

@bartocc
Copy link
Contributor

bartocc commented Aug 27, 2018

I believe the plan for the Faker codemod is to use the faker.js npm package with ember-auto-import, right ?

@samselikoff
Copy link
Collaborator Author

@nightire believe if pretender becomes a peer dep than host apps can choose their own versions

@jherdman
Copy link
Contributor

FYI I've done a little work on the Pretender as a peer dependency thing. Check out #1389

@jherdman
Copy link
Contributor

As of #1392 we support Pretender v2+. 💃

@samselikoff
Copy link
Collaborator Author

c8384bb closes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants
@jherdman @bartocc @nightire @samselikoff and others