From 84f49e77fed3aa2cc7c1e289eb7e3cf75152a452 Mon Sep 17 00:00:00 2001
From: Kevin Barnoin <k.barnoin@gmail.com>
Date: Wed, 11 Dec 2024 10:59:00 +0100
Subject: [PATCH] fix(lbac-2305): remove pending state (#1700)

* fix: remove pending state

* fix: snapshot

* fix: keep status transformation for get single job
---
 .../services/jobs/jobOpportunity/jobOpportunity.service.ts   | 2 +-
 .../openapi/__snapshots__/generateOpenapi.test.ts.snap       | 3 ---
 shared/models/job.model.ts                                   | 5 ++---
 3 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/server/src/services/jobs/jobOpportunity/jobOpportunity.service.ts b/server/src/services/jobs/jobOpportunity/jobOpportunity.service.ts
index 3bb7433e70..a0b5853da9 100644
--- a/server/src/services/jobs/jobOpportunity/jobOpportunity.service.ts
+++ b/server/src/services/jobs/jobOpportunity/jobOpportunity.service.ts
@@ -375,7 +375,7 @@ export const convertLbaRecruiterToJobOfferApi = (offresEmploiLba: IJobResult[]):
               expiration: job.job_expiration_date ?? null,
             },
             opening_count: job.job_count ?? 1,
-            status: translateJobStatus(job.job_status),
+            status: translateJobStatus(job.job_status)!,
           },
 
           workplace: {
diff --git a/shared/helpers/openapi/__snapshots__/generateOpenapi.test.ts.snap b/shared/helpers/openapi/__snapshots__/generateOpenapi.test.ts.snap
index 6c08709076..524bb9c014 100644
--- a/shared/helpers/openapi/__snapshots__/generateOpenapi.test.ts.snap
+++ b/shared/helpers/openapi/__snapshots__/generateOpenapi.test.ts.snap
@@ -9847,7 +9847,6 @@ Limite : 20 appel(s) / 1 seconde(s)
                           "Active",
                           "Filled",
                           "Cancelled",
-                          "Pending",
                         ],
                         "type": "string",
                       },
@@ -10249,7 +10248,6 @@ Limite : 20 appel(s) / 1 seconde(s)
                                   "Active",
                                   "Filled",
                                   "Cancelled",
-                                  "Pending",
                                 ],
                                 "type": "string",
                               },
@@ -10942,7 +10940,6 @@ Limite : 20 appel(s) / 1 seconde(s)
                           "Active",
                           "Filled",
                           "Cancelled",
-                          "Pending",
                         ],
                         "type": "string",
                       },
diff --git a/shared/models/job.model.ts b/shared/models/job.model.ts
index baeaf4f49d..989ab2d25a 100644
--- a/shared/models/job.model.ts
+++ b/shared/models/job.model.ts
@@ -19,10 +19,9 @@ export enum JOB_STATUS_ENGLISH {
   ACTIVE = "Active",
   POURVUE = "Filled",
   ANNULEE = "Cancelled",
-  EN_ATTENTE = "Pending",
 }
 
-export function translateJobStatus(status: JOB_STATUS): JOB_STATUS_ENGLISH {
+export function translateJobStatus(status: JOB_STATUS): JOB_STATUS_ENGLISH | undefined {
   switch (status) {
     case JOB_STATUS.ACTIVE:
       return JOB_STATUS_ENGLISH.ACTIVE
@@ -31,7 +30,7 @@ export function translateJobStatus(status: JOB_STATUS): JOB_STATUS_ENGLISH {
     case JOB_STATUS.ANNULEE:
       return JOB_STATUS_ENGLISH.ANNULEE
     case JOB_STATUS.EN_ATTENTE:
-      return JOB_STATUS_ENGLISH.EN_ATTENTE
+      return undefined
     default:
       assertUnreachable(status)
   }