Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LBA-1326 Modification du lien catalogue des CFAs delegations #1508

Merged
merged 10 commits into from
Sep 16, 2024
Merged

feat: LBA-1326 Modification du lien catalogue des CFAs delegations #1508

merged 10 commits into from
Sep 16, 2024

Conversation

alanlr
Copy link
Collaborator

@alanlr alanlr commented Sep 12, 2024

@alanlr alanlr self-assigned this Sep 12, 2024
@alanlr alanlr requested a review from a team as a code owner September 12, 2024 14:41
@alanlr
Copy link
Collaborator Author

alanlr commented Sep 12, 2024

🚀

@github-actions GitHub Actions
Copy link

To deploy this PR just add a comment with a simple 🚀

@alanlr alanlr marked this pull request as draft September 13, 2024 08:59
@alanlr
Copy link
Collaborator Author

alanlr commented Sep 13, 2024

je vais en profiter pour proprifier le typage ici qui est en TODO

@alanlr alanlr marked this pull request as ready for review September 13, 2024 15:24
@alanlr
Copy link
Collaborator Author

alanlr commented Sep 13, 2024

🚀

@alanlr
Copy link
Collaborator Author

alanlr commented Sep 13, 2024

J'ai un peu débordé sur le périmètre du ticket.

  • récupération du siret pour les établissements
  • lien vers établissement à partir du siret et sur l'url intercarif
  • renommage du formulaire de création d'offre (anciennement AjouterVoeux)
  • typage et modèle zod sur la récupération des établissements proches
  • modification de la manière de limiter les établissements qui remontent --> réduction de la payload qui remonte au client entre 1 et 10 items contre 250 précédemment.

@github-actions GitHub Actions
Copy link

🚀 Prévisualisation

https://1508.labonnealternance-preview.apprentissage.beta.gouv.fr/

You can access runner logs in https://github.com/mission-apprentissage/labonnealternance/actions/runs/10851824817

To re-deploy just add a comment with 🚀

@github-actions GitHub Actions
Copy link

Cypress tests : FAILURE

@alanlr alanlr changed the title feat: LBA-2260 Modification du lien catalogue des CFAs delegations feat: LBA-1326 Modification du lien catalogue des CFAs delegations Sep 16, 2024
@alanlr alanlr merged commit d27130f into main Sep 16, 2024
7 checks passed
@alanlr alanlr deleted the feat/LBA-2260-maj-liens-rco branch September 16, 2024 09:45
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.431.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remy-auricoste remy-auricoste remy-auricoste approved these changes

Assignees

@alanlr alanlr

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanlr @remy-auricoste