Skip to content

Commit 032c01e

Browse files
committed
Migrate release.py to python3
1 parent 28f76bc commit 032c01e

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

.gitlab-ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ undeploy review:
593593
release: &release_template
594594
when: manual
595595
stage: release
596-
image: python:2.7-alpine
596+
image: python:3.8-alpine
597597
before_script:
598598
- apk add --update libmagic openssl
599599
- pip install requests python-magic

ci/release.py

+24-24
Original file line numberDiff line numberDiff line change
@@ -84,37 +84,37 @@ def __call__(self, url, method='GET', parse_json_resp=True,
8484
url = '%s/repos/%s/%s%s' % (api, self.owner, self.repo, url)
8585
headers = kwargs.pop('headers', {})
8686
headers.update({'Authorization': 'token %s' % self.token})
87-
print "Will make %s request to %s: %s" % (method, url, kwargs)
87+
print("Will make %s request to %s: %s" % (method, url, kwargs))
8888
resp = requests.request(method, url, headers=headers, **kwargs)
8989
if not resp.ok:
90-
print resp.status_code
91-
print resp.text
90+
print(resp.status_code)
91+
print(resp.text)
9292
raise Exception(resp.status_code)
9393
if parse_json_resp:
9494
try:
9595
return resp.json()
9696
except Exception:
97-
print "Error decoding json response"
98-
print resp.text
97+
print("Error decoding json response")
98+
print(resp.text)
9999
raise
100100
else:
101101
return resp
102102

103103

104104
def print_release(release):
105-
print '-' * 60
105+
print('-' * 60)
106106
for name, key in [('id', 'id'), ('name', 'name'),
107107
('tag', 'tag_name'), ('ref', 'target_commitish'),
108108
('draft', 'draft'), ('prerelease', 'prerelease')]:
109-
print '%s: %s' % (name, release[key])
110-
print 'assets:'
109+
print('%s: %s' % (name, release[key]))
110+
print('assets:')
111111
for asset in release['assets']:
112-
print ' - %s' % asset['name']
112+
print(' - %s' % asset['name'])
113113
if release['body']:
114-
print 'msg: |'
114+
print('msg: |')
115115
for line in release['body'].splitlines():
116-
print ' %s' % line
117-
print '-' * 60
116+
print(' %s' % line)
117+
print('-' * 60)
118118

119119

120120
def update_release(request, tag, msg=None, files=None,
@@ -129,10 +129,10 @@ def update_release(request, tag, msg=None, files=None,
129129
for item in resp:
130130
if item['name'] == tag:
131131
sha = item['commit']['sha']
132-
print "Tag %s points to %s" % (tag, sha)
132+
print("Tag %s points to %s" % (tag, sha))
133133
break
134134
else:
135-
print "Tag %s doesn't exist" % tag
135+
print("Tag %s doesn't exist" % tag)
136136
sys.exit(1)
137137

138138
# Create or update github release.
@@ -144,26 +144,26 @@ def update_release(request, tag, msg=None, files=None,
144144
'draft': draft,
145145
'prerelease': prerelease,
146146
}
147-
for key, val in data.items():
147+
for key, val in list(data.items()):
148148
if val is None:
149149
data.pop(key)
150150
for release in request('/releases'):
151151
if release['tag_name'] == tag:
152-
print "Found preexisting release."
152+
print("Found preexisting release.")
153153
print_release(release)
154-
for key in data.keys():
154+
for key in list(data.keys()):
155155
if data[key] == release[key]:
156156
data.pop(key)
157157
if data:
158-
print "Release already exists, updating."
158+
print("Release already exists, updating.")
159159
release = request('/releases/%s' % release['id'], 'PATCH',
160160
json=data)
161161
print_release(release)
162162
else:
163-
print "No need to modify release's metadata."
163+
print("No need to modify release's metadata.")
164164
break
165165
else:
166-
print "Creating a new release."
166+
print("Creating a new release.")
167167
release = request('/releases', 'POST', json=data)
168168
print_release(release)
169169

@@ -176,7 +176,7 @@ def update_release(request, tag, msg=None, files=None,
176176
if asset['name'] != name:
177177
continue
178178
assets.pop(i)
179-
print "Found already uploaded file '%s'" % path
179+
print("Found already uploaded file '%s'" % path)
180180
md5 = hashlib.md5()
181181
resp = request('/releases/assets/%s' % asset['id'],
182182
headers={'Accept': 'application/octet-stream'},
@@ -194,10 +194,10 @@ def update_release(request, tag, msg=None, files=None,
194194
md5.update(chunk)
195195
md5sum_local = md5.hexdigest()
196196
if md5sum_local == md5sum_remote:
197-
print "Preexisting file matches local file"
197+
print("Preexisting file matches local file")
198198
uploaded = True
199199
break
200-
print "Deleting preexisting different asset."
200+
print("Deleting preexisting different asset.")
201201
request('/releases/assets/%s' % asset['id'], 'DELETE',
202202
parse_json_resp=False)
203203
if not uploaded:
@@ -209,7 +209,7 @@ def update_release(request, tag, msg=None, files=None,
209209
params={'name': name}, data=fobj)
210210
if remove_undefined_files:
211211
for asset in assets:
212-
print "Deleting preexisting undefined asset %s." % asset['name']
212+
print("Deleting preexisting undefined asset %s." % asset['name'])
213213
request('/releases/assets/%s' % asset['id'], 'DELETE',
214214
parse_json_resp=False)
215215

0 commit comments

Comments
 (0)