Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: utils.validate_data is not compatible with Mistral-Nemo-12B #84

Open
ShadyPi opened this issue Jul 24, 2024 · 0 comments
Open

[BUG]: utils.validate_data is not compatible with Mistral-Nemo-12B #84

ShadyPi opened this issue Jul 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ShadyPi
Copy link

ShadyPi commented Jul 24, 2024

Python Version

Python 3.9.10 (main, Jul 23 2024, 18:16:46) 
[GCC 8.3.0]

Pip Freeze

absl-py==2.1.0
annotated-types==0.7.0
asttokens==2.4.1
attrs==23.2.0
certifi==2024.7.4
charset-normalizer==3.3.2
click==8.1.7
comm==0.2.2
debugpy==1.8.2
decorator==5.1.1
docker-pycreds==0.4.0
docstring_parser==0.16
exceptiongroup==1.2.2
executing==2.0.1
filelock==3.15.4
fire==0.6.0
fsspec==2024.6.1
gitdb==4.0.11
GitPython==3.1.43
grpcio==1.65.1
idna==3.7
importlib_metadata==8.0.0
ipykernel==6.29.5
ipython==8.18.1
jedi==0.19.1
Jinja2==3.1.4
jsonschema==4.21.1
jsonschema-specifications==2023.12.1
jupyter_client==8.6.2
jupyter_core==5.7.2
Markdown==3.6
MarkupSafe==2.1.5
matplotlib-inline==0.1.7
mistral_common==1.3.3
mistral_inference==1.3.1
mpmath==1.3.0
nest-asyncio==1.6.0
networkx==3.2.1
numpy==1.26.4
nvidia-cublas-cu12==12.1.3.1
nvidia-cuda-cupti-cu12==12.1.105
nvidia-cuda-nvrtc-cu12==12.1.105
nvidia-cuda-runtime-cu12==12.1.105
nvidia-cudnn-cu12==8.9.2.26
nvidia-cufft-cu12==11.0.2.54
nvidia-curand-cu12==10.3.2.106
nvidia-cusolver-cu12==11.4.5.107
nvidia-cusparse-cu12==12.1.0.106
nvidia-nccl-cu12==2.19.3
nvidia-nvjitlink-cu12==12.5.82
nvidia-nvtx-cu12==12.1.105
packaging==24.1
pandas==2.2.2
parso==0.8.4
pexpect==4.9.0
platformdirs==4.2.2
prompt_toolkit==3.0.47
protobuf==4.25.3
psutil==6.0.0
ptyprocess==0.7.0
pure_eval==0.2.3
pyarrow==17.0.0
pydantic==2.6.1
pydantic_core==2.16.2
Pygments==2.18.0
python-dateutil==2.9.0.post0
pytz==2024.1
PyYAML==6.0.1
pyzmq==26.0.3
referencing==0.35.1
regex==2024.5.15
requests==2.32.3
rpds-py==0.19.0
safetensors==0.4.3
sentencepiece==0.2.0
sentry-sdk==2.10.0
setproctitle==1.3.3
simple_parsing==0.1.5
six==1.16.0
smmap==5.0.1
stack-data==0.6.3
sympy==1.13.1
tensorboard==2.17.0
tensorboard-data-server==0.7.2
termcolor==2.4.0
tiktoken==0.7.0
torch==2.2.0
tornado==6.4.1
tqdm==4.66.4
traitlets==5.14.3
triton==2.2.0
typing_extensions==4.12.2
tzdata==2024.1
urllib3==2.2.2
wandb==0.17.5
wcwidth==0.2.13
Werkzeug==3.0.3
xformers==0.0.24
zipp==3.19.2

Reproduction Steps

  1. Download the new Mistral-Nemo-12B model. For me, I downloaded the mistralai/Mistral-Nemo-Instruct-2407
  2. Following the guidance in README, fill model path of Mistral-Nemo and data path in example/7B.yaml
  3. Run python -m utils.validate_data --train_yaml example/7B.yaml
  4. You will get ValueError: Provided model folder seems incorrect.

Expected Behavior

utils.validate_data should identify Mistral-Namo correctly.

Additional Context

No response

Suggested Solutions

In utils.validate_data, line 33-37 and line 101-108, it can be seen that Mistral-Nemo is not added into valid model list. There are only 3 options: 7b, 8x7b and 8x22b😢

@ShadyPi ShadyPi added the bug Something isn't working label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant