-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add homebrew support? #14
Comments
I don't see anything blocking this, besides that I read somewhere that homebrew apps should not be GUI binaries afaik: https://stackoverflow.com/questions/26644427/homebrew-only-installs-packages-without-gui But download of the .DMG, when CI can sign and notarize properly, should be easy enough. |
that was quite a while ago, homebrew-cask is now built into the core of brew, so it should be possible, i personally install nearly everything with brew, jetbrains, zed, raycast, arc, etc. is it worth me looking into on your behalf or would you like to? |
I would like you to help me with that. Would it be part of this repository then, or is a separate repo a requirement? If a second one is a requirement, I would really like (not a requirement) to have it under the MW org (I can give you full access to the repo unser the org) If it simply would be part of this repo, you can simply open a PR then I guess. |
i have never done it myself but theres no time like the present to learn, the docs for it are below, as far as i remember you can do it in the same repo and you add a cask file to their (homebrews) repo to make it publicly available. i will do some reading up see if i can come up with something |
what is the minimum major mac version supported (eg. sierra, sequoia)? Edit: i believe it to be catalina and have set it as such |
The official Readme on GitHub says macOS (Big Sur and up). |
I tried to make a pr on the homebrew repo adding it, but they have stated that the app is not signed? is also seems @MattiaTraverso (who i do not know) tried to add bananas to homebrew a few days ago but failed for the same reason this is the message they gave about signing
|
This is true and I already paid Apple 🍎 for a developer license 🙈 I also set up the CI so that it signs and notarizes the app on build and release. But notarizing sometimes can take up to 3 days. I pay per minute on the runners, which is fair, but I won't wait for 3 days to have the app notarized. So my plan is to get #13 done today and then the pipeline does not need to wait for Apple to finish the process. Then, once Apple has notarized the app, a second pipeline will be triggered, which simply downloads the current released version and staples it. Idk if this will work, but I'll try. Yesterday I had one CI running for 35 minutes and still not finished. Another one just 17 minutes before I canceled it. For reference: electron/notarize#179 |
looking online it shouldn't be taking that long, only when something (apples side or not) is wrong. i see the average online being between 10-20 minutes really. and the issue you sent is saying that the command passes a wait flag in which doesnt do anything positive. there is a way to start a gh action using a webhook on:
repository_dispatch:
types: [my_custom_event] curl -X POST \
https://api.github.com/repos/<user>/<repo>/dispatches \
-H "Authorization: token <your_token>" \
-d '{"event_type": "my_custom_event"}' so if you can call that after notorisation has finished? that would save the runners. it would be something like; Push vx.x.x -> gh_actions.build -> notorize -> gh_actions.release. but after calling build the runner sleeps so its not waiting (saving £££) |
That's exactly how I was planning to do it somehow, but not sure if it will work. I theory yes, but that would be to good to be true and I would wonder why it hasn't been done before by the official electron team. |
I tried another time with the unpatched package and it's again running for 18+ minutes now: https://github.com/mistweaverco/bananas/actions/runs/12092128510/job/33733012387 |
taking a look at the log, it doesn't look like its getting to the release script which is where the notorizing would happen right? it looks like |
It hangs in the afterSign script. If I remove that it finishes without problems. |
downloading the app straight from gh, apple used to block it and then you had to go into Settings > Privacy > Allow App, but now it doesn't. i will retry with homebrew and see what happens |
Yes, I added the sign and notarize workflow for the latest 0.0.12 release, should work now ❤️ |
I've submitted the pr, just waiting for a review on it then it should be live 🤞 |
It is live in brew now, you can install it using |
Is there any future plans of this being added to homebrew for quick installation?
The text was updated successfully, but these errors were encountered: