Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updating the uses tag version in gh actions jobs; #288 #295

Closed
wants to merge 1 commit into from

Conversation

rockett-m
Copy link
Contributor

@rockett-m rockett-m commented Jul 27, 2024

debugging docker merge/pull/push and updating the '@ v#' versions within .github/workflows/* as some of them had gotten old / stale (see screenshot below)

stage speedups! vs other PRs in queue

  • doxygen: {before: 3 min 47 sec, now: 44 sec}
  • docker pull_request / docker-build {before: 4 min 1 sec, now: 3 min 24 sec}
  • CI / Build Release Candidate {before: 5 min 24 sec, now: 5 min 4 sec}
  • CI / Unit and Integration Tests {before: 17 min 14 sec, now: 15 min 59 sec}
  • CI / Lint {before: 21 min 33 sec, now: 20 min 36 sec}
gh warnings

@rockett-m
Copy link
Contributor Author

@HalosGhost would you be able to link this with #288 ? Thanks

@HalosGhost HalosGhost linked an issue Jul 27, 2024 that may be closed by this pull request
3 tasks
@HalosGhost
Copy link
Collaborator

@rockett-m is this ready for review?

@rockett-m
Copy link
Contributor Author

rockett-m commented Jul 29, 2024

@HalosGhost not yet, will update when it is
#274 covers all the version upgrades and ubuntu 22.04 upgrade so disregard the github workflow changes here for now

with:
submodules: recursive
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to v5 locally


- name: Set up Docker Buildx (merge)
uses: docker/setup-buildx-action@v1
uses: docker/setup-buildx-action@v2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to v3

@rockett-m
Copy link
Contributor Author

Fixed in #274

@rockett-m rockett-m closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

align docker merge/pull/push github workflows so that CI/CD does not break
2 participants